Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot declare identifying field for a transaction that is not in the system model #21

Closed
dselman opened this issue Oct 28, 2018 · 0 comments
Closed

Cannot declare identifying field for a transaction that is not in the system model #21

dselman opened this issue Oct 28, 2018 · 0 comments
Assignees
@dselman
Labels
Type: Bug 🐛 Something isn't working

Comments

@dselman
Copy link
Contributor

dselman commented Oct 28, 2018

We should remove this code so that people can use Concerto without using a system model.

https://github.com/hyperledger/composer-concerto/blob/master/lib/introspect/transactiondeclaration.js#L71
@dselman dselman added the Type: Bug 🐛 Something isn't working label Oct 28, 2018
@dselman dselman self-assigned this Oct 28, 2018
dselman added a commit to dselman/composer-concerto that referenced this issue Oct 28, 2018
@dselman
allow transactions to specify an identifying field accordproject#21
f1c2ae1 
Signed-off-by: Dan Selman <danscode@selman.org>
dselman added a commit that referenced this issue Oct 29, 2018
@dselman
Fix for #21 - allow transactions to have an identifying field (#22)
fbfa47c 
* refactor modelmanager to standadlone module

Signed-off-by: Dan Selman <danscode@selman.org>

* bump versions, fix linting

Signed-off-by: Dan Selman <danscode@selman.org>

* ignore

Signed-off-by: Dan Selman <danscode@selman.org>

* wip

Signed-off-by: Dan Selman <danscode@selman.org>

* wip

Signed-off-by: Dan Selman <danscode@selman.org>

* Update travis build scripts

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Add webpack build
Signed-off-by: Matt Roberts <code@rbrts.uk>

* Update .travis.yml

Signed-off-by: Matt Roberts <code@rbrts.uk>

* replaced logger with debug

Signed-off-by: Dan Selman <danscode@selman.org>

* removed wallet. Some codecov clean up

Signed-off-by: Dan Selman <danscode@selman.org>

* WIP Remove all references to static system model.

Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix changelog

Signed-off-by: Dan Selman <danscode@selman.org>

* Fix xmlschemavisitor. Increase test coverage

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Revert nyc output to text-summary

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Add pkgbump. Fix webpack. Fix missing moment dependency

* Fix version number

* Add system model table (#5)

* WIP
Signed-off-by: Matt Roberts <code@rbrts.uk>

* Client app has to add system models
Signed-off-by: Matt Roberts <code@rbrts.uk>

* Add system model table

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Move composer models from lib to test. Add test for custom system model

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Remove commented code in assetdeclaration

Signed-off-by: Matt Roberts <code@rbrts.uk>

* switch to yarn

Signed-off-by: Dan Selman <danscode@selman.org>

* travis build

Signed-off-by: Dan Selman <danscode@selman.org>

* remove system model gen

Signed-off-by: Dan Selman <danscode@selman.org>

* first published version

Signed-off-by: Dan Selman <danscode@selman.org>

* (doc) update description

Signed-off-by: Dan Selman <danscode@selman.org>

* (chore) update docs

Signed-off-by: Dan Selman <danscode@selman.org>

* (chore) cleaning

Signed-off-by: Dan Selman <danscode@selman.org>

* (chore) publish latest version

Signed-off-by: Dan Selman <danscode@selman.org>

* allow transactions to specify an identifying field #21

Signed-off-by: Dan Selman <danscode@selman.org>

* bump version

Signed-off-by: Dan Selman <danscode@selman.org>
@dselman dselman closed this as completed Oct 29, 2018
dselman added a commit that referenced this issue Oct 29, 2018
@dselman
Add automatic timestamp field for transactions and events (#24)
5da3e23 
* refactor modelmanager to standadlone module

Signed-off-by: Dan Selman <danscode@selman.org>

* bump versions, fix linting

Signed-off-by: Dan Selman <danscode@selman.org>

* ignore

Signed-off-by: Dan Selman <danscode@selman.org>

* wip

Signed-off-by: Dan Selman <danscode@selman.org>

* wip

Signed-off-by: Dan Selman <danscode@selman.org>

* Update travis build scripts

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Add webpack build
Signed-off-by: Matt Roberts <code@rbrts.uk>

* Update .travis.yml

Signed-off-by: Matt Roberts <code@rbrts.uk>

* replaced logger with debug

Signed-off-by: Dan Selman <danscode@selman.org>

* removed wallet. Some codecov clean up

Signed-off-by: Dan Selman <danscode@selman.org>

* WIP Remove all references to static system model.

Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix changelog

Signed-off-by: Dan Selman <danscode@selman.org>

* Fix xmlschemavisitor. Increase test coverage

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Revert nyc output to text-summary

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Add pkgbump. Fix webpack. Fix missing moment dependency

* Fix version number

* Add system model table (#5)

* WIP
Signed-off-by: Matt Roberts <code@rbrts.uk>

* Client app has to add system models
Signed-off-by: Matt Roberts <code@rbrts.uk>

* Add system model table

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Move composer models from lib to test. Add test for custom system model

Signed-off-by: Matt Roberts <code@rbrts.uk>

* Remove commented code in assetdeclaration

Signed-off-by: Matt Roberts <code@rbrts.uk>

* switch to yarn

Signed-off-by: Dan Selman <danscode@selman.org>

* travis build

Signed-off-by: Dan Selman <danscode@selman.org>

* remove system model gen

Signed-off-by: Dan Selman <danscode@selman.org>

* first published version

Signed-off-by: Dan Selman <danscode@selman.org>

* (doc) update description

Signed-off-by: Dan Selman <danscode@selman.org>

* (chore) update docs

Signed-off-by: Dan Selman <danscode@selman.org>

* (chore) cleaning

Signed-off-by: Dan Selman <danscode@selman.org>

* (chore) publish latest version

Signed-off-by: Dan Selman <danscode@selman.org>

* allow transactions to specify an identifying field #21

Signed-off-by: Dan Selman <danscode@selman.org>

* bump version

Signed-off-by: Dan Selman <danscode@selman.org>

* Automatically add a timestamp field to transactions and events

Signed-off-by: Dan Selman <danscode@selman.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dselman dselman

Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dselman