reverse spread of props on mapPropsOnChange

[hartzis]

fix for #102

[codecov-io]

Current coverage is 100.00%

Merging #104 into master will not affect coverage as of 34150c8

@@            master    #104   diff @@
======================================
  Files           42      42       
  Stmts          325     325       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            325     325       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 34150c8

Powered by Codecov. Updated on successful CI builds.

[hartzis]

CI build failed due to:

Module build failed: Error: The (relay-query) Babel 5 plugin is being run with Babel 6.

I think it is related to facebook/relay#889, and when they publish a new version it may be fixed.

[hartzis]

blocked by tests failing, #106

[hartzis]

@acdlite merged in master to get tests to run, and fixed the broken tests. Should be good to go now.

[acdlite]

Thanks!

[istarkov]

PS: PR omit props
IMHO omit should be removed.

I'll explain why:

One of my most used construction with mapPropsOnChange was

mapPropsOnChange(
  ['a', 'b', 'c'], 
  ({...props, a, b ,c}) => ({
    ...props,
    someResult: blabla(a,b,c)
  })
),

spread operator allows me to not lost a,b,c in the future, and reuse them again.

Now to make this work I can't use spread operator at all, because other props out of selection array i.e. ['a', 'b', 'c'] will be placed in this.computedProps so will be outdated.

The code above now looks like

mapPropsOnChange(
  ['a', 'b', 'c'], 
  ({a, b ,c}) => ({
    a,
    b,
    c,
    someResult: blabla(a,b,c)
  })
),

So every time I add property into selection array I need to add it into object to preserve.

Removing omit will help a lot, I could just remove all that ...props, and forget about property omitting logic in mapPropsOnChange