missile_manpad - add MANPADs and IR seeker #10031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
removed IR seeker impl due to it existing in #10022 |
TheCandianVendingMachine
changed the title
TheCandianVendingMachine
changed the base branch from
missile_aim9
to
master
TheCandianVendingMachine
changed the base branch from
master
to
missile_aim9
PabstMirror
reviewed
Sep 20, 2024
| @@ -59,6 +59,7 @@ PREP(mwr_onFired); | |||
| PREP(IR_onFired); | |||
|
|
|||
| // Navigation OnFired | |||
| PREP(los_onFired); | |||
There was a problem hiding this comment.
Suggested change
| PREP(los_onFired); | |
| PREP(navigationType_lineOfSight); |
I think this is right
There was a problem hiding this comment.
yeah, los_onFired originally was a copy of pronav_onFired, but I reduced them to the same file for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Merge Strategy
Follow #10019
Merge after #10022
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.