Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightvision - Improve NVG Brightness adjustment limits #10136

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Nightvision - Improve NVG Brightness adjustment limits #10136

merged 7 commits into from
Aug 2, 2024

Conversation

SpicyBagpipes
Copy link
Contributor

When merged this pull request will:

  • Move hardcoded limits for nvg brightness adjustment to variables

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

LinkIsGrim
LinkIsGrim requested changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation.

addons/nightvision/XEH_postInit.sqf Outdated Show resolved Hide resolved
@SpicyBagpipes
Copy link
Contributor Author

Documentation.

9d761c9

@PabstMirror PabstMirror added this to the 3.18.0 milestone Jul 21, 2024
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 21, 2024
jonpas
jonpas reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of const if the intention is easier changing than before?

@SpicyBagpipes
Copy link
Contributor Author

What is the point of const if the intention is easier changing than before?

Not meant to be changed mid-mission as is max/min

@PabstMirror
Copy link
Contributor

a var that you can chang named const is a little bit funny but it's similar to what we did in #7236

@LinkIsGrim @PabstMirror
load order independence
dad09a2 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@LinkIsGrim LinkIsGrim merged commit 90d855c into acemod:master Aug 2, 2024
5 checks passed
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@SpicyBagpipes @PabstMirror
@LinkIsGrim @blake8090
Nightvision - Improve NVG Brightness adjustment limits (acemod#10136)
daeb069 
* Update fnc_changeNVGBrightness.sqf

* Update XEH_postInit.sqf

* Update addons/nightvision/XEH_postInit.sqf

Co-authored-by: PabstMirror <pabstmirror@gmail.com>

* Update XEH_postInit.sqf

* Update fnc_changeNVGBrightness.sqf

* Update nightvision-framework.md

* load order independence

Co-authored-by: PabstMirror <pabstmirror@gmail.com>

---------

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

@DartRuffian DartRuffian DartRuffian left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SpicyBagpipes @PabstMirror @jonpas @DartRuffian @LinkIsGrim