Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zeus unit and group interactions locality #5214

Merged
merged 4 commits into from
May 31, 2017
Merged

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented May 28, 2017

  • The setUnitPos, setFormation, setSpeedMode and setBehaviour commands require local arguments
  • The waypoint equivalents require server execution

- The `setUnitPos` and `setBehaviour` commands require local arguments
- I'm assuming the `setFormation` and `setSpeedMode` commands do too, but
  unconfirmed
- Unsure about the waypoint commands too, will have to investigate
@kymckay kymckay added this to the 3.10.0 milestone May 28, 2017
@kymckay kymckay self-assigned this May 28, 2017
@kymckay
Copy link
Member Author

kymckay commented May 28, 2017

So I went ahead and tested the locality of all the commands not marked on the biki. Some interesting results, apparently the waypoint commands need to be executed on the server, rather than where the group is local. Will update code and biki with this information.

@@ -79,3 +78,33 @@ GVAR(isOpeningDoor) = false;

["isNotSwimming", {!underwater (_this select 0)}] call EFUNC(common,addCanInteractWithCondition);
["isNotOnLadder", {getNumber (configFile >> "CfgMovesMaleSdr" >> "States" >> animationState (_this select 0) >> "ACE_isLadder") != 1}] call EFUNC(common,addCanInteractWithCondition);

// Zeus action events
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These EH are below line 31 - if (!hasInterface) exitWith {};

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@kymckay kymckay merged commit cbe06e5 into master May 31, 2017
@kymckay kymckay deleted the zeusinteractfix branch May 31, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants