Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair - Add enable setting #8070

Merged
merged 13 commits into from
Jul 29, 2023
Merged

Repair - Add enable setting #8070

merged 13 commits into from
Jul 29, 2023

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

veteran29
veteran29 previously requested changes Jan 17, 2021
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor optimization.

addons/repair/CfgEden.hpp Outdated Show resolved Hide resolved
addons/repair/CfgEden.hpp Outdated Show resolved Hide resolved
addons/repair/CfgEden.hpp Outdated Show resolved Hide resolved
Dystopian and others added 2 commits January 17, 2021 21:03
@Dystopian @veteran29
Optimize eden expressions
668614b 
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
@Dystopian
Merge remote-tracking branch 'upstream/master' into repair-no-compat
3ee54e1
LinkIsGrim
LinkIsGrim requested changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setUnitTrait ["Engineer", true] by any third party will break things, but that's a compromise we'll have to make for no item replacements.

addons/repair/functions/fnc_addRepairActions.sqf Outdated Show resolved Hide resolved
addons/repair/initSettings.sqf Outdated Show resolved Hide resolved
addons/repair/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/repair/CfgVehicles.hpp Outdated Show resolved Hide resolved
@Dystopian
Copy link
Contributor Author

Dystopian commented Jul 16, 2023 •
edited
Loading

Will do also some tests these days after upstream merging.

Dystopian and others added 2 commits July 17, 2023 23:04
@Dystopian
Fix strange indent
e15cbd2
@Dystopian @LinkIsGrim
Optimize bool to number conversion
942fffd 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Jul 17, 2023
@LinkIsGrim LinkIsGrim mentioned this pull request Jul 17, 2023
Closed
3 tasks
@LinkIsGrim
Copy link
Contributor

@mharis001 ZEN Engineer Attribute will need to be updated with this.

@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Jul 29, 2023
@LinkIsGrim LinkIsGrim merged commit 14e92df into acemod:master Jul 29, 2023
5 checks passed
@PabstMirror PabstMirror mentioned this pull request Aug 17, 2023
Merged
@LinkIsGrim LinkIsGrim mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautamiekka rautamiekka rautamiekka left review comments

@PabstMirror PabstMirror PabstMirror left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@veteran29 veteran29 veteran29 left review comments

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Dystopian @LinkIsGrim @rautamiekka @veteran29 @PabstMirror