Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles - Add Resume/Set functionality to speed control #8967

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • add Set/Resume functionality on Speed-/Speed+ keys (like SET-/RES+ buttons)
  • make Autothrottle work for UAV planes
  • fix Autothrottle not working for copilots
  • fix speed control for UGV gunner
  • disable speed control activating if engine is off
  • disable speed control activating in UAV when map is opened
  • disable CC activating if speed < 1 (stopped or moving backward)
  • disable speed control when Feature Camera starts (Zeus, Splendid Camera, etc.)

Speed Control means Cruise Control and Speed Limiter here.

I don't know if it's worth touching setting strings. I would just add / Resume to <English>Increase Speed Limit</English> line but not for other languages. Deleting them would be rude to translators. Commenting them out would be good but tabler sees commented lines as missing.

Looks like UGV are correctly driven by player as gunner. These are Stomper (Car child), ED-1D and ED-1E (Tank children). And speed control works correctly with gunner too now.

I also had idea to store speedLimit and isCruiseControl vars per vehicle but decided it's not worth it.

Copy link
Member

@BrettMayson BrettMayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works good for me in SP

addons/vehicles/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/vehicles/functions/fnc_autoThrottle.sqf Outdated Show resolved Hide resolved
addons/vehicles/functions/fnc_speedLimiter.sqf Outdated Show resolved Hide resolved
Co-authored-by: BrettMayson <brett@mayson.io>
@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Jun 28, 2023
@jonpas jonpas added this to the 3.16.0 milestone Jun 28, 2023
@LinkIsGrim LinkIsGrim merged commit 22b93e2 into acemod:master Jun 28, 2023
@Dystopian Dystopian deleted the cruise-resume branch June 29, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants