Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookoff - Remove flares from cookoff #9146

Merged
merged 6 commits into from
Mar 18, 2023

Conversation

Cyruz143
Copy link
Contributor

@Cyruz143 Cyruz143 commented Feb 5, 2023

When merged this pull request will:

  • Omit flares from vehicle cook-off

Not sure how much of an impact this has to vanilla arma but anyone with bright flares will know the eye burning, soul scortching pain of a vehicle exploding when it's loaded with flares. The particles all start to break as 10 flares all cook off on one spot.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror PabstMirror added this to the 3.16.0 milestone Feb 18, 2023
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Feb 18, 2023
@PabstMirror
Copy link
Contributor

PabstMirror commented Feb 18, 2023

Wasn't there a problems with flares floating in air during cookoff?
-Meaning this might not need a setting.

@Cyruz143
Copy link
Contributor Author

Wasn't there a problems with flares floating in air during cookoff? -Meaning this might not need a setting.

Not sure tbh pabst, cookoff does spawn the ammo usually at the turret height (iirc) so potentially, yes

@PabstMirror
Copy link
Contributor

20230219204141_1
recent example of tracers just hovering over a burning wreck
(this can be handled another time)

but I also think we can just remove all these problematic ammo types without a setting

@Drofseh
Copy link
Contributor

Drofseh commented Feb 24, 2023

20230219204141_1 recent example of tracers just hovering over a burning wreck (this can be handled another time)

but I also think we can just remove all these problematic ammo types without a setting

iirc this happens when the velocity of the spawned ammo is too low.

Personally though I've never been a fan of the ammo shooting out, especially on armored vehicles. A) it would be exploding inside the vehicle so it couldn't fly out, B) even if it could fly out of would only go a couple meters, not the dozens of meters that happens in ace cookoff

@Cyruz143
Copy link
Contributor Author

As per chat, removed setting

@Cyruz143 Cyruz143 changed the title Cookoff - Add option for flare removal Cookoff - Remove flares from cookoff Feb 28, 2023
@PabstMirror PabstMirror merged commit 2092d4f into acemod:master Mar 18, 2023
@Cyruz143 Cyruz143 deleted the cookoff_flare_removal branch March 20, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants