Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Fix added throwables not being throwable #9186

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

Wakbub
Copy link
Contributor

@Wakbub Wakbub commented Apr 19, 2023

Replace
- addMagazineCargoGlobal with addItemTo(Uniform/Vest/Backpack to make added throwables throwable.
@mharis001
Copy link
Member

What about using addMagazineAmmoCargo?

@Wakbub
Copy link
Contributor Author

Wakbub commented Apr 19, 2023

addMagazineAmmoCargo has the same limitation as addMagazineCargoGlobal in that it makes added throwables not being throwable.

@Wakbub
Copy link
Contributor Author

Wakbub commented Apr 19, 2023

A complete solution may perhaps:

@LinkIsGrim
Copy link
Contributor

We should look at (finally) fixing ammo count for magazines in fnc_addToInventory later.

@LinkIsGrim LinkIsGrim merged commit 117c309 into acemod:master Jun 24, 2023
@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Jun 24, 2023
@jonpas jonpas added this to the 3.16.0 milestone Jun 24, 2023
@jonpas
Copy link
Member

jonpas commented Jun 24, 2023

Reasoning should really be put in a comment in code, or it'll just get reverted one day.

@LinkIsGrim
Copy link
Contributor

I'll make a note to go touch that and make ammo count work with defined containers.

@Wakbub Wakbub deleted the throwables branch October 11, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to throw converted explosives
4 participants