Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload - Code cleanup and various improvements #9343

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Improvements/Changes:
    • Previously, when linking a belt, a magazine was removed upon the action start from the unit's (who was trying to link) inventory and readded in case of failure. This PR changes it: It now only removes the magazine at the end of the progressbar upon successful completion. It will check if it was able to remove the magazine; if not, the interaction is cancelled.
    • Upon completion or failure of a belt linking, a notification shows up. Reload/ReloadLauncher - Add notifications when buddy loading or linking #9202 (or a follow-up PR) could be made to disable these notifications.
    • Previously, there was some very specific behaviour concerning UGLs and checking of their ammo. This has been expanded to where if any secondary muzzle has no ammo left, it will show the number of compatible magazines on the unit.
    • CBA events are now added to connected machines that don't have interfaces. I imagine this could cause issues if the unit you are trying to link a belt to is local to a dedicated server or headless client. I don't remember coming across problems stemming from this, but it's a safety measure that doesn't impact performance greatly.
    • If displayNameShort for static weapon magazines can't be found, displayName is used instead. I don't recall encountering an issue caused from the lack of a displayNameShort entry, but it's a small safeguard that doesn't cost much.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Aug 26, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Aug 26, 2023
addons/reload/functions/fnc_getAmmoToLinkBelt.sqf Outdated Show resolved Hide resolved
addons/reload/initKeybinds.sqf Show resolved Hide resolved
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@LinkIsGrim LinkIsGrim merged commit 44e0fdb into acemod:master Aug 28, 2023
5 checks passed
@johnb432 johnb432 deleted the reload-refactor branch January 14, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants