Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo - Improve cargo space values #9418

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Cargo - Improve cargo space values #9418

merged 1 commit into from
Sep 23, 2023

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Sep 21, 2023 •
edited
Loading

When merged this pull request will:

  • Alter cargo space for vehicles depending on the size/realistic space you would expect within the vehicle.
  • Added Laws of War Transport/Cargo Van
  • Things like Repair trucks would have low amounts of space since apparently they carry everything they need to repair any vehicle.
  • I didn't touch object space size as I feel it's perfectly fine as is, just vehicles.
  • Fixed the comments as they were bothering me.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added kind/enhancement Release Notes: **IMPROVED:** area/compatibility labels Sep 22, 2023
LinkIsGrim
LinkIsGrim approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all sensible IMO.

jonpas
jonpas approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like.

@jonpas jonpas added this to the 3.16.0 milestone Sep 22, 2023
@LinkIsGrim LinkIsGrim merged commit b4940e6 into master Sep 23, 2023
5 checks passed
@jonpas jonpas deleted the cargo-values branch September 23, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mike-MF @jonpas @LinkIsGrim