Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging - Add new colors to sprays and new tag and tweak stringtables. #9443

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

Apricot-ale
Copy link
Contributor

@Apricot-ale Apricot-ale commented Sep 29, 2023

When merged this pull request will:

  • Add Yellow Spray Paint. Yellow is used for team color but missing.
  • Add White Spray Paint. Useful for dark color walls.
  • Add Filled Square tag, Useful for identifications.
  • Remove color variations from the "X" strings and unify it.
  • Tweak some Japanese strings.

I have carefully translated the color word into each language, so I don't think there has problem, but please change it if necessary.
Also, if @BaerMitUmlaut maintains templates for textures and UI for spray, consider replacing the images with those.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Add:
Yellow Splay
White Splay
Filled Square tag for all colors

Change (and remove):
Remove color variations from the "X" strings and unify it.
Tweak some Japanese strings.
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Oct 1, 2023
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Oct 1, 2023
@LinkIsGrim LinkIsGrim merged commit 6429d06 into acemod:master Oct 1, 2023
5 checks passed
@Apricot-ale Apricot-ale deleted the tagging branch December 4, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants