Audit of regexps: ^ become \A, $ become \Z #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all files needed ot be changed, and maybe some of these changes won't make a difference.
|
I think we need \z instead of \Z, because unfortunately \Z matches a line ending at the end of the string, which is not what we want |
The method is stull buggy, a comment was added.
| Revision_info=CbrainFileRevision[__FILE__] #:nodoc: | ||
|
|
||
| # Iterator that validates a username, UNIX style | ||
| def validate_each(object, attribute, value) #:nodoc: |
There was a problem hiding this comment.
You have a nodoc here but there is in fact documentation. Maybe remove it?
|
There is a regex on line 744 of BarinPortal/public/javascripts/userfiles.js that still has ^ and $ |
|
That's because it's javascript code, and javascript regex don't support \A and \z |
|
This RegEx audit should extend to the plugins as well |
|
I already looked at the plugins, there's not much to change there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all files needed ot be changed, and maybe some of these
changes won't make a difference.