This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Fix a number of issues #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were uncovered when researching commercialhaskell/stack#105. What I discovered: * There was an extra layer of `.git` directories in computed paths * The HEAD file should be added dependently regardless of whether it's a detached head * Add a missing check in relRef for newline * Switch newline handling to check both CR and LR for Windows support
|
Bumping |
|
Bump |
|
FWIW, tested the patch — it does fix Absolutely must-merge. |
|
Ping @acfoltzer pls pls merge this PR. Thanks. |
|
I'm fine with merging this but I do not develop Haskell any longer, so have no means of testing it myself. Please feel free to make a fork if you'd like to continue further development of this project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were uncovered when researching commercialhaskell/stack#105. What
I discovered:
.gitdirectories in computed pathsdetached head