Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does this relate to gitrev #11

Closed
dzhus opened this issue Apr 11, 2019 · 3 comments · Fixed by anoma/juvix#2308
Closed

How does this relate to gitrev #11

dzhus opened this issue Apr 11, 2019 · 3 comments · Fixed by anoma/juvix#2308

Comments

@dzhus
Copy link
Contributor

dzhus commented Apr 11, 2019

I was wondering what's the relation between githash and https://hackage.haskell.org/package/gitrev – judging by b15d219 and package upload date it looks like githash is an improved version of gitrev? I feel like there should be a small note on that in README to avoid confusion.

@snoyberg
Copy link
Owner

Doc PR welcome. I'm not really sure what information you're looking for, lots of libraries on Hackage provide similar functionality. This is a fork of gitrev because patches I sent upstream were ignored

acfoltzer/gitrev#15

@snoyberg
Copy link
Owner

snoyberg commented Sep 3, 2019

Looks like this is addressed, closing

@snoyberg snoyberg closed this as completed Sep 3, 2019
@ivan-m
Copy link

ivan-m commented Jan 15, 2020

@snoyberg though there are still some references to gitrev in the repo (the LICENSE, an example, etc.)

paulcadman added a commit to anoma/juvix that referenced this issue Aug 23, 2023
This PR replaces [gitrev](https://hackage.haskell.org/package/gitrev)
with [githash](https://hackage.haskell.org/package/githash) which
provides more reliable git information about the current git info, it
seems to work as expected. githash originated as a fork of gitrev
containing fixes snoyberg/githash#11

This PR also fixes the issue with git info detection in the linux static
build. There was a permission issue in the build container that caused
git cli calls to fail.

Closes:
* #2294
* #2130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants