Fix Cxx17 incompatibility issues #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slicer switched to C++14 which resulted in the hardcoded C++ standard version in CIP causing a configuration conflict. Fixed by making the version configurable externally.
Fix issues such as: "CIP/Utilities/LesionSizingToolkit/itkCannyEdgeDetectionRecursiveGaussianImageFilter.h:196:47: error: ISO C++1z does not allow dynamic exception specifications"
|
@rjosest please merge or grant me write access to this repository so that I can commit. It is important that we can integrate such fixes quickly, otherwise we need to keep using our fork. Thank you! |
|
Unfortunately, we need to switch back to using our fork :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITK, VTK, etc. libraries require more recent C++ standard version (Cxx17) and CIP had build errors in this environment. These commits fix the build errors.