Skip to content

Remove route auto injection #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2016
Merged

Remove route auto injection #8

merged 1 commit into from
Mar 22, 2016

Conversation

jderusse
Copy link
Contributor

For the following reasons:

  • To complicate for a smal benefit (avoid 1 copy/paste)
  • The user is not able to change the order of loading (for instance, when he define a "catch all" route)

tgalopin
tgalopin reviewed Mar 22, 2016
View reviewed changes
features/bootstrap/FeatureContext.php
@@ -86,8 +86,6 @@ public function theFollowingAcmePhpConfiguration(PyStringNode $rawConfig)
*/
public function certificateShouldBeGenerated($count)
{
var_dump($this->storageDir);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

tgalopin added a commit that referenced this pull request Mar 22, 2016
@tgalopin
Merge pull request #8 from jderusse/revert-router-autoregistration
66599cc 
Remove route auto injection
@tgalopin tgalopin merged commit 66599cc into acmephp:master Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jderusse @tgalopin