Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landing page styles #38

Merged
merged 2 commits into from
Oct 24, 2021
Merged

Update landing page styles #38

merged 2 commits into from
Oct 24, 2021

Conversation

louisphn
Copy link

@louisphn louisphn commented Oct 23, 2021

Closes #26

  • Updated landing page styles according to proposed design
    Preview:
    image

Scopes:

  • Changed files: AppHeader.tsx, pages/index.tsx, pages/_app.tsx
  • New files: lib/data.ts, styles/header.module.css, styles/landing.module.css

PS: Responsive layout has not been featured yet, if it is necessary please let me know

@vercel
Copy link

vercel bot commented Oct 23, 2021

Someone is attempting to deploy a commit to the ACM UTD Team on Vercel.

A member of the Team first needs to authorize it.

@abdullah50053
Copy link
Collaborator

Could you use TailwindCSS instead of vanilla CSS?
Aside from that, everything looks great.

@vercel
Copy link

vercel bot commented Oct 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/acmutd/hackportal/7xpsH27i3jv3iYtkZiE4StaU2Per
✅ Preview: https://hackportal-git-fork-louisphn-feat-landing-page-styling-acmutd.vercel.app

auto-merge was automatically disabled October 23, 2021 23:00

Head branch was pushed to by a user without write access

@louisphn
Copy link
Author

I have changed all vanilla css styling to Tailwindcss and here is a preview of landing page:
image

Please take a look when you have time and let me know if there is anything needed to be changed

@abdullah50053
Copy link
Collaborator

Looks good! Thanks for your contributions to open source, and I recommend you take a look at issues #27 #28 #29 and #30 if you'd like to continue work on the landing page :)

@WillieCubed WillieCubed merged commit cdc1f83 into acmutd:develop Oct 24, 2021
@WillieCubed WillieCubed changed the title feat:update landing page style Update landing page styles Oct 24, 2021
@DedsecKnight DedsecKnight mentioned this pull request Oct 24, 2021
12 tasks
DedsecKnight added a commit that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Landing Page Styling
4 participants