Implement about page #40

DedsecKnight · 2021-10-24T03:32:34Z

Changes made in this PR:

vercel · 2021-10-24T03:32:36Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/acmutd/hackportal/5TLYbnAyfWaxtGBs7KTLRFFGJkzD
✅ Preview: https://hackportal-git-feature-about-section-acmutd.vercel.app

WillieCubed · 2021-10-24T03:32:55Z

📝 Changed routes:

/about/faq	/about
^{(view full size)}	^{(view full size)}

/about/questions
^{(view full size)}

And 5 other routes:

Commit 0c3b031 (https://hackportal-bvdze3mgb-acmutd.vercel.app).

abdullah50053 · 2021-10-24T04:20:59Z

I've reviewed the current code and everything looks good. Will come back to the PR once the "Next Steps" have been completed.

WillieCubed

A valiant contribution. This PR is not close to ready for a merge because functionality - especially for the FAQ - has not been implemented. Anything merged into the develop branch needs to have working functionality, and the contributions far need to be closer to completion to warrant being merged. Additionally, there are some lingering documentation issues that need to be addressed.

pages/about/questions.tsx

pages/about/index.tsx

pages/about/faq.tsx

components/FaqDisclosure.tsx

components/PendingQuestion.tsx

components/FaqDisclosure.tsx

components/AnsweredQuestion.tsx

components/AboutHeader.tsx

WillieCubed · 2021-10-24T04:54:48Z

I recommend marking this pull request as a draft until you have completed implementation of the features that this PR is supposed to address.

Moved color schemes list from utilities file to component file to make it local to the component only

Reformat components from anonymous functions to standard named functional component. Also renamed Props interface to use standard component properties name

Moved hardcoded data to lib/data.ts. Setup flow such that hardcoded data can be easily replaced with logic to fetch real data from backend

Added documentation to components created for About section

WillieCubed · 2021-10-25T17:00:31Z

Here's the error:

11:55:15.141 Cloning github.com/acmutd/hackportal (Branch: feature/about-section, Commit: 16133b2)
11:55:15.678 Cloning completed: 536.905ms
11:55:15.701 Analyzing source code...
11:55:17.128 Installing build runtime...
11:55:20.028 Build runtime installed: 2.899s
11:55:23.136 Looking up build cache...
11:55:27.196 Build cache downloaded [62.29 MB]: 3700.307ms
11:55:28.398 Installing dependencies...
11:55:28.405 Detected package-lock.json generated by npm 7...
11:55:30.834 > hackportal@0.1.0 prepare
11:55:30.834 > husky install
11:55:30.905 husky - Git hooks installed
11:55:30.915 up to date in 2s
11:55:30.915 131 packages are looking for funding
11:55:30.915 run npm fund for details
11:55:30.925 Detected Next.js version: 11.1.0
11:55:30.934 Running "npm run build"
11:55:31.220 > hackportal@0.1.0 build
11:55:31.220 > next build
11:55:33.187 info - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
11:55:34.598 info - Checking validity of types...
11:55:44.063 ./pages/about/faq.tsx
11:55:44.064 31:6 Warning: React Hook useEffect has a missing dependency: 'getFaqs'. Either include it or remove the dependency array. react-hooks/exhaustive-deps
11:55:44.064 ./pages/about/index.tsx
11:55:44.065 37:6 Warning: React Hook useEffect has a missing dependency: 'getMembersData'. Either include it or remove the dependency array. react-hooks/exhaustive-deps
11:55:44.065 ./pages/about/questions.tsx
11:55:44.066 111:6 Warning: React Hook useEffect has a missing dependency: 'getAllQuestions'. Either include it or remove the dependency array. react-hooks/exhaustive-deps
11:55:44.066 ./pages/auth/signOut.tsx
11:55:44.067 21:6 Warning: React Hook React.useEffect has a missing dependency: 'signOut'. Either include it or remove the dependency array. react-hooks/exhaustive-deps
11:55:44.067 info - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
11:55:44.067 info - Creating an optimized production build...
11:55:44.148 > [PWA] Compile client (static)
11:55:44.148 > [PWA] Auto register service worker with: /vercel/path0/node_modules/next-pwa/register.js
11:55:44.148 > [PWA] Service worker: /vercel/path0/public/sw.js
11:55:44.148 > [PWA] url: /sw.js
11:55:44.148 > [PWA] scope: /
11:55:44.343 > [PWA] Compile server
11:55:46.441 warn - You have enabled the JIT engine which is currently in preview.
11:55:46.441 warn - Preview features are not covered by semver, may introduce breaking changes, and can change at any time.
11:55:59.914 info - Compiled successfully
11:55:59.915 info - Collecting page data...
11:56:01.004 info - Generating static pages (0/16)
11:56:01.522 info - Generating static pages (4/16)
11:56:01.535 info - Generating static pages (8/16)
11:56:01.583 Error occurred prerendering page "/about". Read more: https://nextjs.org/docs/messages/prerender-error
11:56:01.583 FetchError: request to http://localhost:3000/api/members failed, reason: connect ECONNREFUSED 127.0.0.1:3000
11:56:01.583 at ClientRequest. (/vercel/path0/node_modules/node-fetch/lib/index.js:1461:11)
11:56:01.583 at ClientRequest.emit (events.js:400:28)
11:56:01.584 at Socket.socketErrorListener (_http_client.js:475:9)
11:56:01.584 at Socket.emit (events.js:400:28)
11:56:01.584 at emitErrorNT (internal/streams/destroy.js:106:8)
11:56:01.584 at emitErrorCloseNT (internal/streams/destroy.js:74:3)
11:56:01.584 at processTicksAndRejections (internal/process/task_queues.js:82:21)
11:56:01.591 info - Generating static pages (12/16)
11:56:01.598 Error occurred prerendering page "/about/faq". Read more: https://nextjs.org/docs/messages/prerender-error
11:56:01.598 FetchError: request to http://localhost:3000/api/questions/faq failed, reason: connect ECONNREFUSED 127.0.0.1:3000
11:56:01.598 at ClientRequest. (/vercel/path0/node_modules/node-fetch/lib/index.js:1461:11)
11:56:01.598 at ClientRequest.emit (events.js:400:28)
11:56:01.598 at Socket.socketErrorListener (_http_client.js:475:9)
11:56:01.599 at Socket.emit (events.js:400:28)
11:56:01.599 at emitErrorNT (internal/streams/destroy.js:106:8)
11:56:01.599 at emitErrorCloseNT (internal/streams/destroy.js:74:3)
11:56:01.599 at processTicksAndRejections (internal/process/task_queues.js:82:21)
11:56:02.149 info - Generating static pages (16/16)
11:56:02.149 > Build error occurred
11:56:02.151 Error: Export encountered errors on following paths:
11:56:02.151 /about
11:56:02.151 /about/faq
11:56:02.151 at /vercel/path0/node_modules/next/dist/export/index.js:474:19
11:56:02.152 at runMicrotasks ()
11:56:02.152 at processTicksAndRejections (internal/process/task_queues.js:95:5)
11:56:02.152 at async Span.traceAsyncFn (/vercel/path0/node_modules/next/dist/telemetry/trace/trace.js:60:20)
11:56:02.152 at async /vercel/path0/node_modules/next/dist/build/index.js:752:17
11:56:02.152 at async Span.traceAsyncFn (/vercel/path0/node_modules/next/dist/telemetry/trace/trace.js:60:20)
11:56:02.152 at async /vercel/path0/node_modules/next/dist/build/index.js:630:13
11:56:02.153 at async Span.traceAsyncFn (/vercel/path0/node_modules/next/dist/telemetry/trace/trace.js:60:20)
11:56:02.235 Error: Command "npm run build" exited with 1

It appears that you're explicitly making a request to https://localhost:3000 when that value should not be hardcoded. You can also reproduce this error by running npm run build locally.

Resolve error regarding attempting to make request to localhost:3000 on staging environment

Resolves warnings came from React when using useEffect hook

When user fails to submit question, appropriate error message will be shown in a user-friendly way.

abdullah50053

Vercel-specific issues will be identified by @WillieCubed
Everything else looks good.

WillieCubed

This is incredibly Gucci!

For a future release, I will recommend updating the answered questions in realtime by using the relevant Cloud Firestore API or telling the user that they will have to refresh to see the answered questions. However, the only major change to make is showing the expanded answered questions by default as it's not clear to the user they need to click on the answers to expand them as that's an important part of UX that will likely get overlooked by the user.

WillieCubed

LGTM!

feat(aboutsection): Implemented UI of About Section

8cdd3c1

DedsecKnight requested a review from abdullah50053 as a code owner October 24, 2021 03:32

DedsecKnight linked an issue Oct 24, 2021 that may be closed by this pull request

[Feature Request] Add About section #36

Closed

DedsecKnight marked this pull request as draft October 24, 2021 03:33

abdullah50053 marked this pull request as ready for review October 24, 2021 03:48

DedsecKnight changed the title ~~feat(aboutsection): Implemented UI of About Section~~ feat(about): Implemented UI of About Section Oct 24, 2021

WillieCubed enabled auto-merge October 24, 2021 04:33

WillieCubed disabled auto-merge October 24, 2021 04:33

WillieCubed changed the title ~~feat(about): Implemented UI of About Section~~ Implement about page Oct 24, 2021

WillieCubed self-requested a review October 24, 2021 04:35

WillieCubed suggested changes Oct 24, 2021

View reviewed changes

DedsecKnight added 2 commits October 24, 2021 00:09

feat(about): Added member card to "Meet our Team" section

831c51e

chore(about): Moved color schemes list

425ec7d

Moved color schemes list from utilities file to component file to make it local to the component only

DedsecKnight marked this pull request as draft October 24, 2021 05:26

DedsecKnight added 2 commits October 24, 2021 00:41

feat(about): Added color variation to 'My Answered Question'

0aa3bf2

style(about): Reformat code

430a9d0

Reformat components from anonymous functions to standard named functional component. Also renamed Props interface to use standard component properties name

vercel bot deployed to Preview October 24, 2021 05:49 View deployment

fix(app-header): Resolve conflict with #38

45f03a9

vercel bot deployed to Preview October 24, 2021 18:00 View deployment

Merge branch 'develop' into feature/about-section

e636f7a

vercel bot deployed to Preview October 24, 2021 18:01 View deployment

fix(about): Resolves issues with hardcoded data

20d0932

Moved hardcoded data to lib/data.ts. Setup flow such that hardcoded data can be easily replaced with logic to fetch real data from backend

vercel bot deployed to Preview October 24, 2021 19:14 View deployment

DedsecKnight added 3 commits October 24, 2021 15:08

feat(about): Implemented expand all FAQs

34d23a0

docs(about): Added documentation

9ef37d6

Added documentation to components created for About section

docs(about): Added more details to documentation

24bd40e

vercel bot had a problem deploying to Preview October 25, 2021 16:55 Failure

fix(about): Fixed error when making requests to backend

f9d7666

Resolve error regarding attempting to make request to localhost:3000 on staging environment

vercel bot deployed to Preview October 25, 2021 18:37 View deployment

DedsecKnight added 3 commits October 25, 2021 13:51

fix(about): Resolves warning with useEffect

ed6c535

Resolves warnings came from React when using useEffect hook

chore: Removed unused stuff and fake datas

b1d416d

feat: Added Error Handling for when user submit questions

aa94bfc

When user fails to submit question, appropriate error message will be shown in a user-friendly way.

vercel bot deployed to Preview October 25, 2021 19:41 View deployment

DedsecKnight requested a review from WillieCubed October 25, 2021 19:43

DedsecKnight marked this pull request as ready for review October 25, 2021 19:47

abdullah50053 linked an issue Oct 29, 2021 that may be closed by this pull request

[Feature Request] Add ability to ask organizers a question #9

Closed

abdullah50053 removed a link to an issue Oct 29, 2021

[Feature Request] Add ability to ask organizers a question #9

Closed

abdullah50053 previously approved these changes Oct 29, 2021

View reviewed changes

Merge branch 'develop' into feature/about-section

070c167

vercel bot deployed to Preview October 30, 2021 05:11 View deployment

WillieCubed enabled auto-merge November 6, 2021 00:39

abdullah50053 requested review from nam-t24, Balstun and MelissaAvila706 November 6, 2021 00:51

WillieCubed suggested changes Nov 6, 2021

View reviewed changes

refactor(about): Set disclosure default state to open

f4e289a

DedsecKnight dismissed abdullah50053’s stale review via f4e289a November 6, 2021 04:10

vercel bot deployed to Preview November 6, 2021 04:10 View deployment

Merge branch 'develop' into feature/about-section

0c3b031

vercel bot deployed to Preview November 6, 2021 04:33 View deployment

WillieCubed approved these changes Nov 6, 2021

View reviewed changes

WillieCubed requested a review from abdullah50053 November 6, 2021 04:36

abdullah50053 approved these changes Nov 6, 2021

View reviewed changes

WillieCubed merged commit ae74886 into develop Nov 6, 2021

WillieCubed deleted the feature/about-section branch November 6, 2021 04:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement about page #40

Implement about page #40

DedsecKnight commented Oct 24, 2021 •

edited

Loading

vercel bot commented Oct 24, 2021 •

edited

Loading

WillieCubed commented Oct 24, 2021 •

edited

Loading

abdullah50053 commented Oct 24, 2021

WillieCubed left a comment

WillieCubed commented Oct 24, 2021

WillieCubed commented Oct 25, 2021 •

edited

Loading

abdullah50053 left a comment

WillieCubed left a comment •

edited

Loading

WillieCubed left a comment

Implement about page #40

Implement about page #40

Conversation

DedsecKnight commented Oct 24, 2021 • edited Loading

Changes made in this PR:

vercel bot commented Oct 24, 2021 • edited Loading

WillieCubed commented Oct 24, 2021 • edited Loading

📝 Changed routes:

abdullah50053 commented Oct 24, 2021

WillieCubed left a comment

Choose a reason for hiding this comment

WillieCubed commented Oct 24, 2021

WillieCubed commented Oct 25, 2021 • edited Loading

abdullah50053 left a comment

Choose a reason for hiding this comment

WillieCubed left a comment • edited Loading

Choose a reason for hiding this comment

WillieCubed left a comment

Choose a reason for hiding this comment

DedsecKnight commented Oct 24, 2021 •

edited

Loading

vercel bot commented Oct 24, 2021 •

edited

Loading

WillieCubed commented Oct 24, 2021 •

edited

Loading

WillieCubed commented Oct 25, 2021 •

edited

Loading

WillieCubed left a comment •

edited

Loading