Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get explicit path of mktemp & use that for invoking #83

Closed
wants to merge 1 commit into from
Closed

Get explicit path of mktemp & use that for invoking #83

wants to merge 1 commit into from

Conversation

CrystalSpore
Copy link

cygwin environment doesn't have mktemp on path by default (or at least this script can't use mktemp when using the command name directly within cygwin)
This fix works both in Linux/standard environments & in cygwin

cygwin environment doesn't have mktemp on path by default (or at least this script can't use mktemp when using the command name directly within cygwin)
@CrystalSpore
Copy link
Author

Seems there is a deeper issue with cygwin, as I found a new different edge case. I'll open a new pr when I have the full fix

@CrystalSpore
Copy link
Author

cygwin does "magic setup" of the path variables in /etc/profile, but that does not run during fish startup, so instead of setting an environment variable in windows to set fish as the default shell, instead add

source /etc/profile
exec -l fish "$@"

to the .bashrc file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant