Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-586: Support syncing private files from remote #3616

Closed
bkosborne opened this issue May 3, 2019 · 3 comments · Fixed by #3853
Closed

DT-586: Support syncing private files from remote #3616

bkosborne opened this issue May 3, 2019 · 3 comments · Fixed by #3853
Labels
Enhancement A feature or feature request

Comments

@bkosborne
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A remote site uses private files. I want to sync these private files locally. The blt drupal:sync:files command does not sync private files, only public.

Describe the solution you'd like
A config option that includes private files when running blt drupal:sync:files, and/or an additional command like blt drupal:sync:files:private

@bkosborne bkosborne added the Enhancement A feature or feature request label May 3, 2019
@bkosborne
Copy link
Contributor Author

I think drush may have support for this "private" variable already: drush-ops/drush#1113

@danepowell
Copy link
Contributor

Makes sense. Not sure how people would use this most often, but I'm guessing it would make the most sense to have a sync.private-files config option. If it's set, then sync private files whenever drupal:sync:files happens.

This isn't a feature request we get often so it's not a high priority right now, but I'll put it on the roadmap. If you want to have it sooner PRs are welcome or you can advocate for it via a Support ticket.

@danepowell danepowell added this to the 10.2.0 milestone May 3, 2019
@danepowell danepowell changed the title Support syncing private files from remote DT-586: Support syncing private files from remote Aug 20, 2019
danepowell added a commit to danepowell/blt that referenced this issue Sep 18, 2019
@danepowell
Copy link
Contributor

danepowell commented Sep 19, 2019

#3853 will add this functionality. Note that there's a potential bug in the currently implementation of local private files, which can cause conflicts if you are syncing multiple sites locally: #3854

Specifically, I think syncing a default site would wipe out any multisite private files locally.

danepowell added a commit that referenced this issue Sep 23, 2019
* DT-586: Fixes #3616: Support syncing of private files.

* Added drupal:sync:public-files alias.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants