Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-586: Fixes #3616: Support syncing of private files. #3853

Merged
merged 2 commits into from
Sep 23, 2019
Merged

DT-586: Fixes #3616: Support syncing of private files. #3853

merged 2 commits into from
Sep 23, 2019

Conversation

danepowell
Copy link
Contributor

Fixes #3616

Changes proposed

  • Add drupal:sync:private-files command
  • Add sync.private-files config option
  • Modify blt sync to call drupal:sync:private-files if sync.private-files is TRUE.

Steps to replicate the issue

  1. Have a BLT project with a remote alias (cloud environment) defined, which has private files
  2. Run blt sync -Dsync.private-files=true and verify that private files are synced to <repo-root>/files-private.

@danepowell danepowell added the Enhancement A feature or feature request label Sep 18, 2019
adrianthedev
adrianthedev approved these changes Sep 19, 2019
View reviewed changes
Copy link

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danepowell danepowell mentioned this pull request Sep 19, 2019
Closed
@danepowell danepowell mentioned this pull request Sep 23, 2019
Closed
@danepowell danepowell merged commit 514a0a0 into acquia:10.x Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexxed alexxed alexxed approved these changes

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees
No one assigned
Labels
Enhancement A feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DT-586: Support syncing private files from remote
3 participants
@danepowell @adrianthedev @alexxed