Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1035: drupal-composer/drupal-scaffold conflicts with drupal/core-composer-scaffold #3929

Closed
CraigGardener opened this issue Nov 26, 2019 · 4 comments · Fixed by #3942
Closed

Comments

@CraigGardener
Copy link
Contributor

From Drupal 8.8 it is recommended to use the drupal/recommended-project composer project template as per https://www.drupal.org/docs/develop/using-composer/starting-a-site-using-drupal-composer-project-templates.

Adding BLT to this currently fails due to the conflict between drupal/core-composer-scaffold (new scaffold plugin, maintained by core team) and drupal-composer/drupal-scaffold (old scaffold plugin, not maintained by core team).

BLT should require the new drupal/core-composer-scaffold plugin instead.

@danepowell
Copy link
Contributor

Not sure if this is a dupe of #3563 (comment), but I think my comment there still applies.

The problem is that BLT 11 will support both Drupal 8.7 and 8.8. Since drupal-scaffold and composer-scaffold are mutually exclusive, BLT has to choose one or the other, I don't see how to support both. I think we have to stick with Drupal scaffold until we drop support for Drupal 8.7 at its EOL (May 2020).

Do you know of any way around that?

@CraigGardener
Copy link
Contributor Author

CraigGardener commented Nov 27, 2019 via email

@danepowell
Copy link
Contributor

danepowell commented Dec 4, 2019

We're still considering how to handle Composer Scaffold going forward. In the meantime, there's nothing stopping you from using Drupal 8.8 today with BLT 10/11. Although Composer Scaffold is recommended, Drupal Scaffold will work just fine until Drupal 8.9. However if you already have a Drupal 8.8 project using Composer Scaffold, you are correct that you can't add BLT to it today.

@danepowell danepowell changed the title drupal-composer/drupal-scaffold conflicts with drupal/core-composer-scaffold DT-1035: drupal-composer/drupal-scaffold conflicts with drupal/core-composer-scaffold Dec 4, 2019
@danepowell danepowell added this to the Backlog milestone Dec 4, 2019
@danepowell
Copy link
Contributor

danepowell commented Dec 4, 2019

I think we're going to fix this in three phases:

  1. In this ticket, move the drupal-scaffold dependency from BLT's composer.json to the blt-project template composer.json. This will fix the immediate issue of not being able to add BLT to an existing Drupal 8.8 project. It will also let people manage Drupal/Composer scaffold however they'd like until we can implement the next steps.
  2. Switch the blt-project template composer.json to Composer Scaffold. (Use composer-scaffold to build new BLT projects #3563) Note that this will create new BLT projects using Composer Scaffold, but existing projects won't be affected. That's why we need...
  3. A migration command to help people move from Drupal Scaffold to Composer Scaffold prior to its removal/full deprecation in Drupal 8.9.

danepowell added a commit to danepowell/blt that referenced this issue Dec 6, 2019
danepowell added a commit that referenced this issue Dec 9, 2019
…3942)

* DT-1035: Fixes #3929: Move Drupal Scaffold to project composer.json.

* Code style fix.

* Updated ORCA SUT version.

* Patch orca to get dev blt project.

* Removed ORCA patch.

* Revert "Removed ORCA patch."

This reverts commit 28e10f9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants