-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-1035: Fixes #3929: Move Drupal Scaffold to project composer.json. #3942
Conversation
ORCA is pulling the 10.x stable release of blt-project, which is doubly bad because it should be 11.x, and it should also be the dev version from this PR. |
👍 |
@phenaproxima @TravisCarden BLT's ORCA builds here have suddenly started hitting the missing vfsStream dependency problem, as you can see in the last test run above (maybe because we forgot to update the SUT version 🙄 ). Did ya'll end up patching that in ORCA? Just wondering how to get this build passing. @alexxed @adrianthedev please review this despite the failing test if you don't mind, so we can get it merged Monday. |
@danepowell I'm actually rolling an ORCA hotfix for this issue right now. I'll report back shortly. |
@danepowell I released the hotfix and restarted your failing build, but it now fails due to a patch that no longer applies. Obviously, I can't fix that for you on my side. |
We still need the patch from acquia/orca#52 (against ORCA |
This reverts commit 28e10f9.
Fixes #3929
Changes proposed
Steps to replicate the issue
blt update
, ensure that Drupal Scaffold is added to your composer.json file and otherwise nothing changes.Additional details
Should have no functional impact on projects, but it will free them and us up to migrate to Composer Scaffold at one's leisure. I don't want to backport this to 10.x since it requires a manual run of
composer update
, which users should be doing anyway during the 11.x upgrade.