-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-artifact step in Pipelines Causes dev/tty Write Errors #4251
Comments
FWIW I poked at this extensively and as far as I can tell, the |
Does I doubt BLT is doing anything wrong here because our canary builds are running fine in Pipelines, and I know that Symfony has a lot of TTY detection logic that would fall over if we were calling it incorrectly. But I also know that Robo / Symfony changed this recently, and it's definitely conceivable that upgrading Symfony (as for Drupal 9) would break something. |
I added an npm install command to our canary build and reproduced this. Looks like it only happens in Pipelines, not Travis, which is not surprising, Symfony and Robo haven't been very consistent about detecting TTY in the past in Pipelines. |
I ran into this as well with a Probo.ci environment. It started thinking it was in an interactive shell after updating to BLT 12 and Drupal 9. I also fixed it by explicitly telling it was not an interactive shell. |
@bkosborne How did you specify it to be non interactive? I'm updating from Drupal 8.9 -> 9.0 (so also BLT 11 -> 12)
BLT version: 12.8.2.0 |
@dhaggman Just pass |
This is related to #4195.
Describe the bug
After updating to Drupal 9 and BLT 12, my builds are failing in the artifact build stage in Pipelines (not locally) with:
This is notable for a few reasons:
After some experimentation, I was able to find this in Robo: https://github.com/consolidation/Robo/blob/3.x/src/Common/ExecTrait.php#L354
I'm thinking that something about our invokeHooks may be setting something as interactive. When I force the following to FALSE my build passes w/o issue: https://github.com/acquia/blt/blob/12.x/src/Robo/BltTasks.php#L181
To Reproduce
Steps to reproduce the behavior, ideally starting from a fresh install of BLT:
Expected behavior
Either both the artifact and source both fail or both pass (not one of each)
Detailed error output
System information
The text was updated successfully, but these errors were encountered: