Fix #4251: TTY mode errors on Pipelines artifact builds #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4251
Proposed changes
Run Pipelines artifact builds explicitly non-interactively.
Alternatives considered
Chase down whatever component of the Symfony/Robo stack is incorrectly treating Pipelines as an interactive environment when it's not, as it's definitely a bug. Unfortunately I don't have time to chase it down right now.
Coincidentally, the other major open bug in the BLT queue is about Drupal Check, which was the last component to have TTY problems. Maybe there's some useful info here if anyone wants to dive in: mglaman/drupal-check#135
Testing steps
Apply this PR as patch, run a Pipelines build with a deploy step.