Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable prestissimo check for Composer 2 #4292

Closed
djvern opened this issue Dec 4, 2020 · 3 comments · Fixed by #4296
Closed

Disable prestissimo check for Composer 2 #4292

djvern opened this issue Dec 4, 2020 · 3 comments · Fixed by #4296
Labels
Enhancement A feature or feature request

Comments

@djvern
Copy link

djvern commented Dec 4, 2020

When running blt doctor the check for the hirak/prestissimo plugin is flagged as a minor issue. However I've deliberately removed this as I'm using Composer 2 and the prestissimo plugin is not required or compatible.

Can the check detect if Composer 2 is installed and not run if that's the case?
@djvern djvern added the Enhancement A feature or feature request label Dec 4, 2020
@danepowell
Copy link
Contributor

Actually we might want to have doctor alert if people are still using Composer 1 since it will be EOL soon, and Composer 2 is so much more performant.

danepowell added a commit to danepowell/blt that referenced this issue Dec 11, 2020
@danepowell
DX-3021: Fix acquia#4292: Check for Composer 2 instead of prestissimo
8c790f7
@danepowell danepowell mentioned this issue Dec 11, 2020
Merged
@danepowell
Copy link
Contributor

@djvern would you like to test #4296 ?

danepowell added a commit that referenced this issue Dec 14, 2020
@danepowell
DX-3021: Fix #4292: Check for Composer 2 instead of prestissimo (#4296)
9b9a627 
* DX-3021: Fix #4292: Check for Composer 2 instead of prestissimo

* Fix tests
@djvern
Copy link
Author

djvern commented Dec 17, 2020

Thanks @danepowell, this works for me 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement A feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DX-3021: Fix #4292: Check for Composer 2 instead of prestissimo danepowell/blt
2 participants
@djvern @danepowell