Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX-3021: Fix #4292: Check for Composer 2 instead of prestissimo #4296

Merged
merged 2 commits into from
Dec 14, 2020
Merged

DX-3021: Fix #4292: Check for Composer 2 instead of prestissimo #4296

merged 2 commits into from
Dec 14, 2020

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes #4292

Proposed changes

Consider Composer 1 end of life, and advise users to upgrade. Specifically:

  • Get rid of prestissimo and composer-drupal-optimizations checks, as these are no longer necessary with Composer 2
  • Advise (not warn or error, yet) if Composer 1 is detected

@danepowell danepowell mentioned this pull request Dec 11, 2020
Closed
@danepowell danepowell added 12.x Affects or applies to 12.x Enhancement A feature or feature request labels Dec 11, 2020
@danepowell danepowell merged commit 9b9a627 into acquia:12.x Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12.x Affects or applies to 12.x Enhancement A feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable prestissimo check for Composer 2
1 participant
@danepowell