Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1276: no-scripts doesn't disable composer hooks #1688

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes #1276

Proposed changes

Passing --no-scripts to any command that supports it will disable Composer command hooks.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Run a command such as acli pull:code --no-scripts -v.
  4. Verify you don't see any messages in the output about composer scripts.

@danepowell danepowell added the bug Something isn't working label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bc2749) 91.08% compared to head (b1607f2) 91.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1688      +/-   ##
============================================
+ Coverage     91.08%   91.09%   +0.01%     
+ Complexity     1786     1785       -1     
============================================
  Files           122      122              
  Lines          6368     6367       -1     
============================================
  Hits           5800     5800              
+ Misses          568      567       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit 388a4cb into acquia:main Feb 21, 2024
12 checks passed
@danepowell danepowell deleted the CLI-1276 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant