Fixes #339: Store multiple Acquia Cloud tokens in local file. #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
commented
Feb 3, 2021
grasmash
commented
Feb 3, 2021
| $list = []; | ||
| foreach ($items as $item) { | ||
| $list[$item->$unique_property] = trim($item->$label_property); | ||
| if (is_array($item)) { | ||
| $list[$item[$unique_property]] = trim($item[$label_property]); |
There was a problem hiding this comment.
Is there a universal way to access a property that works for both arrays and objects?
|
Tests are passing. Code coverage went down 0.02%. I think that may be ok. I don't see any good place to add more test coverage. |
grasmash
commented
Feb 3, 2021
grasmash
commented
Feb 4, 2021
danepowell
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Experience:
acli logina. If no keys are saved locally, prompt to enter new key.
b. If keys already exist locally, prompt user to choose among existing keys or create a new key.
i. If selected existing key, set it as the default key for ACLI.
ii. If create new key, prompt to enter new key.
acli logouta. Unset the default key for ACLI, but do not remove the key from the filesystem.
This PR includes an automated migration path.