improve(OVM_SpokePool): Use bridgeERC20To to bridge native L2 tokens if admin decides to support them #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will allow future OpStack chains to more easily inherit Ovm_SpokePool without having to modify `_bridgeTokensToHubPool` due to custom SNX logic
…if admin decides to support them bridgeERC20To can be used to bridge native L2 tokens (without L1 counterparts and specifically does not contain a `l1Token()` function in the L2 erc20 contract) if an L1 remote token is identified. This call require the spoke pool to set an allowance on the standard bridge before calling `bridgeERC20To`
… tokens if admin decides to support them" This reverts commit 3d09986.
…2 tokens if admin decides to support them" This reverts commit 4258fdd.
pxrl
approved these changes
Jun 14, 2024
bmzig
approved these changes
Jun 14, 2024
Co-authored-by: Paul <108695806+pxrl@users.noreply.github.com>
nicholaspai
added a commit
that referenced
this pull request
Jun 17, 2024
…eToBase interface Leftover from #520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bridgeERC20To can be used to bridge native L2 tokens (without L1 counterparts and specifically does not contain a
l1Token()function in the L2 erc20 contract) if an L1 remote token is identified.This call require the spoke pool to set an allowance on the standard bridge before calling
bridgeERC20To