-
Notifications
You must be signed in to change notification settings - Fork 64
fix: incorrect token information in response for wetheth #1867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a23e8cd
535425d
d802692
21ca59a
fbaac20
1ee0789
538dacf
0393983
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,4 +165,24 @@ describe("GET /swap/approval", () => { | |
); | ||
}); | ||
}); | ||
|
||
test("should return WETH for Base and Linea", async () => { | ||
const params = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the original sample request from the Linear ticket: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT: I also didn't specify it in the ticket but what happens if you set the zero address as the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I created in issue for this here: https://linear.app/uma/issue/ACX-4504/fix-the-incorrect-token-information-for-all-native-tokens |
||
tradeType: "exactInput", | ||
amount: "10000000000000000", | ||
inputToken: "0x4200000000000000000000000000000000000006", | ||
outputToken: "0xe5D7C2a44FfDDf6b295A15c148167daaAf5Cf34f", | ||
originChainId: 8453, | ||
destinationChainId: 59144, | ||
depositor: "0xB8034521BB1a343D556e5005680B3F17FFc74BeD", | ||
recipient: "0xB8034521BB1a343D556e5005680B3F17FFc74BeD", | ||
includeSources: "uniswap_v3", | ||
}; | ||
const response = await axios.get(SWAP_API_URL, { | ||
params, | ||
}); | ||
expect(response.status).toBe(200); | ||
expect(response.data.inputToken.symbol).toBe("WETH"); | ||
expect(response.data.outputToken.symbol).toBe("WETH"); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: We didn't specify it in the ticket but now that I review this, this bug happens for all native tokens, e.g. XPL, GHO. So this fix will not work for them 🤔 We can tackle this is in a separte PR/issue though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created in issue here: https://linear.app/uma/issue/ACX-4504/fix-the-incorrect-token-information-for-all-native-tokens