Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the 2 letters syntax for values #141

Merged
merged 3 commits into from
Apr 3, 2015
Merged

Conversation

thierryk
Copy link
Contributor

@thierryk thierryk commented Apr 1, 2015

No description provided.

@yahoocla
Copy link

yahoocla commented Apr 1, 2015

CLA is valid!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 570f202 on add-cursor-values into 7363e20 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 570f202 on add-cursor-values into 7363e20 on master.

@renatoi
Copy link
Contributor

renatoi commented Apr 2, 2015

You will review all value identifiers we have today, right? So I guess we will either see a new PR or you update this one.

@thierryk
Copy link
Contributor Author

thierryk commented Apr 2, 2015

yes, but I don't remember if we said we were going for the 1st letter of syllables or only fixing things where we don't have 2 letters for separated words value.

@src-code
Copy link
Contributor

src-code commented Apr 2, 2015

@thierryk I'd think the latter, but what might be some examples of the former?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f26b79f on add-cursor-values into 7363e20 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f26b79f on add-cursor-values into 7363e20 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f26b79f on add-cursor-values into 7363e20 on master.

@thierryk
Copy link
Contributor Author

thierryk commented Apr 2, 2015

@src-code my last commit is to follow the "1st letter for each word sepearted bu a -" pattern. I really think we should leave it at that because the Emmet syntax follows some arbitrary syntax.
For example we have this:

{suffix: 'tbcl', values: ['table-column']},
{suffix: 'tbclg', values: ['table-column-group']},
{suffix: 'tbhg', values: ['table-header-group']},
{suffix: 'tbfg', values: ['table-footer-group']},
{suffix: 'tbrg', values: ['table-row-group']}

Emmet made a few calls such as:

  • z stands for size
  • tb stands for table no matter where it is found
  • ma stands for max and mi for min.

With the latter, they do not follow the pattern we adopted. For example, they do not use mc for max-content but maxc. Which makes sense since it avoids conflict with min-content in a nicer way than we would (mc and mic).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 36f961d on add-cursor-values into 7363e20 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 36f961d on add-cursor-values into 7363e20 on master.

@src-code
Copy link
Contributor

src-code commented Apr 2, 2015

LGTM.

thierryk added a commit that referenced this pull request Apr 3, 2015
Follow the 2 letters syntax for values
@thierryk thierryk merged commit 07fba03 into master Apr 3, 2015
@thierryk thierryk deleted the add-cursor-values branch April 21, 2015 15:39
redonkulus pushed a commit that referenced this pull request Jul 14, 2022
…-1.11.1

Bump nokogiri from 1.10.10 to 1.11.1 in /docs
redonkulus pushed a commit that referenced this pull request Jul 14, 2022
…-1.11.1

Bump nokogiri from 1.10.10 to 1.11.1 in /docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants