-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow the 2 letters syntax for values #141
Conversation
CLA is valid! |
1 similar comment
You will review all value identifiers we have today, right? So I guess we will either see a new PR or you update this one. |
yes, but I don't remember if we said we were going for the 1st letter of syllables or only fixing things where we don't have 2 letters for separated words value. |
@thierryk I'd think the latter, but what might be some examples of the former? |
2 similar comments
@src-code my last commit is to follow the "1st letter for each word sepearted bu a {suffix: 'tbcl', values: ['table-column']},
{suffix: 'tbclg', values: ['table-column-group']},
{suffix: 'tbhg', values: ['table-header-group']},
{suffix: 'tbfg', values: ['table-footer-group']},
{suffix: 'tbrg', values: ['table-row-group']} Emmet made a few calls such as:
With the latter, they do not follow the pattern we adopted. For example, they do not use |
1 similar comment
LGTM. |
Follow the 2 letters syntax for values
…-1.11.1 Bump nokogiri from 1.10.10 to 1.11.1 in /docs
…-1.11.1 Bump nokogiri from 1.10.10 to 1.11.1 in /docs
No description provided.