Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining expectation 2 and 3 #1652

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Joining expectation 2 and 3 #1652

merged 2 commits into from
Jun 22, 2021

Conversation

tbostic32
Copy link
Collaborator

Joining expectation 2 and 3 makes this rule follow the same pattern as shown in the video element content is media alternative for text, which I prefer as it is overall more concise.

Closes issue(s):

Need for Final Call:
This will not require a Final Call - The changes to the expectation do not affect how the rule is interpreted and so are purely editorial and to be more concise.


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

Joining expectation 2 and 3 makes this rule follow the same pattern as shown in the [video element content is media alternative for text](https://act-rules.github.io/rules/ab4d13), which I prefer as it is overall more concise.
@WilcoFiers WilcoFiers merged commit 685eede into act-rules:develop Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rejected/clarification needed - "audio element content is media alternative for text" (afb423)
5 participants