Skip to content

Update image-no-text-0va7u6.md #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 22, 2022
Merged

Update image-no-text-0va7u6.md #1873

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8c73e1
Update image-no-text-0va7u6.md
ChrisLoiselle Jun 21, 2022
4ff8fae
Update image-no-text-0va7u6.md
ChrisLoiselle Jul 8, 2022
7e96dee
Update _rules/image-no-text-0va7u6.md
ChrisLoiselle Jul 28, 2022
55d8e72
Update _rules/image-no-text-0va7u6.md
ChrisLoiselle Jul 28, 2022
01b4bc1
Update _rules/image-no-text-0va7u6.md
ChrisLoiselle Aug 3, 2022
a79c282
Update _rules/image-no-text-0va7u6.md
ChrisLoiselle Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions _rules/image-no-text-0va7u6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ This rule applies to any [rendered image resources][] in a [web page][].

## Expectation

For each test target, at least one of the following is true:

For each test target, its [visible pixels][visible] do not contain text expressing anything in a [human language], except if at least one of the following is true:

- **essential**: the [visible pixels][visible] of the test target contain text for which its presentation is [essential][]; or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure we should use "essential" here. It's sort of out of scope of this PR, but it's very relevant in moving this rule forward. We had a discussion about "essential" last week in ACT TF and our impression there was that it was too ambiguous to be used in an expectation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WilcoFiers , your points seem to point at both including and excluding it. I'm happy to have a discussion to decide on what we are doing within the most recent submission for updates.

Copy link
Member

@WilcoFiers WilcoFiers Sep 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open an issue. This is not related to your PR. Feel free to move forward with that. #1915

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I can resolve this conversation ? I see #1915 however not sure what to do with #1873 currently.

- **language**: the [visible pixels][visible] of the test target do not contain text expressing anything in a [human language][]; or
- **significant**: the [visible pixels][visible] of the test target contain text and the text is not a significant part of the [visible pixels][visible] of the test target; or
- **decoration**: the [embedded image][] the test target belongs to is [purely decorative][].
- **not significant**: the [visible pixels][visible] of the test target contain text and the text is not a significant part of the visible part of the image or
- **decoration**: the test target belongs to an [embedded image][] that is [purely decorative][].

## Assumptions

Expand Down