-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[73f2c2] Autocomplete invalid - Accessibility note clarifies HTML spec's disallowed autocomplete values for specific form controls #2161
Conversation
Added accessibility support note and removed "ambiguous example"
Call for review ends on February 21st. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that Passed Example 8 should not be a pass:
- the normative wording of the SC mentions 'programatically determinable' but it's only the understanding document that talks about autocomplete
- Passed Example 8 has two incompatible programatically determinable meanings: one from input=tel, the other from autocomplete=bday-day (both of these are exposed via MSAA / IAccessible2 / UIA )
- The understanding document says the intent of the technique is for user agents to extract and present this purpose to users using different modalities
In this example some modalities convey the meaning as input=tel, and other modalities as autocomplete=bday-day. For example, VoiceOver with Safari announces this as "telephone number field", but somebody using AT to overlay icons on input fields might see a birthday cake icon next to the field (representing birthday day)
If this interpretation is correct, then I think this means the wording about "Thus, if the input possesses the suitable autocomplete ... regardless of type" probably needs to change.
Edit: ... and if this interpretation is correct, Passed Example 8 should probably be a fail rather removed completely
…ue-vs-form-control-type-patch
Quickly browsing through the old issue this fixes, this looks like a case where UA + AT do not behave fully consistently. Moreover, in case of conflicting information ( At the same time, I also agree that we shouldn't have a Passed Example like that. It is quite certainly failing the SC, as explained by Mark, so it shouldn't be a Passed Example (tools / methodologies that are smarter than the rule and correctly fail it should still have a consistent implementation). It feels like we'd want to just discard the inappropriate So, I think the only solution is to keep going as this PR does, maybe buffing up a bit the new note to explain that inappropriate We may want to add a rule checking that (valid) |
CG: can you document any accessibility support issues related to passed example 8 before we merge this? |
@giacomo-petri I'm removing Call for Review since it looks like #2161 (comment) needs action. |
Replaced "Certain `autocomplete` attribute values are appropriate only for specific form controls. However, despite some combinations of `autocomplete` attribute values and form controls not being allowed by HTML specifications, the input purpose is programmatically available, and autocomplete functions correctly. Thus, if the input possesses the suitable autocomplete value, it fulfills the [Success Criterion 1.3.5 Identify Input Purpose](https://www.w3.org/TR/WCAG22/#identify-input-purpose), regardless of the input type." with "Authors may assign inappropriate `autocomplete` attribute values. Moreover, HTML specifications restrict certain `autocomplete` attribute values to specific form controls. Mismatches between `autocomplete` attribute values and form control types may or may not lead to a failure of [Success Criterion 1.3.5 Identify Input Purpose](https://www.w3.org/TR/WCAG22/#identify-input-purpose). However, this rule focuses exclusively on validating valid `autocomplete` attribute values, disregarding their contextual appropriateness."
Replaced background note:
with
|
@dd8, I believe we've covered all the points discussed. We've received 4 approvals, but I'd appreciate your final review, especially considering your previous concerns with the earlier version. Thanks |
…ue-vs-form-control-type-patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect - that fixes it
Call for review ends on May 8th |
…ue-vs-form-control-type-patch
Call for review has ended. Merging. |
Closes issue: #1967
Need for Call for Review:
This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve