-
Notifications
You must be signed in to change notification settings - Fork 78
chore: Validating rules frontmatter on CI #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. Thanks Jey!
rules.forEach(ruleData => { | ||
const { filename } = ruleData | ||
describe(filename, () => { | ||
describe(groupName, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh bummer. Looks like this nesting describe doesn't work in Jest. :( Might as well put this into a single describe
then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does the below:
jest
, for testing & assertions.rules
exist.frontmatter
attributes.frontmatter
attributes based onrule_type
.h2
headings.h3
headings.Closes issue: