-
Notifications
You must be signed in to change notification settings - Fork 78
fix: test if definition for all referenced glossary terms exist #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The changes requested does not aim to solve the actual problem of missing glossary definitions.
To fix the media ones: @JKODU
|
Given that (i) our definition of "semantic role" already mention implicit ones; and (ii) that in the very same rule, "explicit semantic role" is already pointing to "semantic role": |
Note: All definition references are fixed, waiting for #604 before this is merged. |
## Applicability | ||
|
||
Any HTML or SVG element that has an [explicit semantic role](#semantic-role), except if the element has an [implicit semantic role](#implicit-role) that is identical to the explicit semantic role. | ||
Any HTML or SVG element that has an [explicit semantic role](#semantic-role), except if the element has an [implicit semantic role](#semantic-role) that is identical to the explicit semantic role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely isn't the way to solve it. I think we need a definition for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, do we also need a definition for "explicit semantic role" which is used in the very same rule and simply links to "semantic role"?
The definition of semantic role has mention of both implicit and explicit roles, with links to further explanations. I assumed that if it was OK to link "explicit semantic role" to it, then it would also be OK for "implicit semantic role".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilcoFiers I do not understand why it is fine to have [explicit semantic role](#semantic-role)
(as was here before), but it is not fine to have [implicit semantic role](#semantic-role)
Especially given that the glossary entry for semantic role mention both implicit and explicit roles, with links to more details.
Could you explain why one is OK and the other is not?
Should we rather add definitions for both explicit and implicit roles? (they are going to essentially be the same links that already exist in the definition of "Semantic Role")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. We shouldn't have linked explicit semantic role to semantic role either. I'll open an issue for it, as to not block this PR any further.
@WilcoFiers can you respond on this - #634 (comment) |
Added a test to check if content/ definition actually exists for a used glossary term in rules. In other words to check if a glossary referred actually exists as a file in
/pages/glossary/*.md
@annethyme @Jym77 - could you help fix up the missing glossary items?
Failed tests report:
Closes issue: