Skip to content

Conversation

jeeyyy
Copy link
Collaborator

@jeeyyy jeeyyy commented Jul 4, 2019

Use correct html tag for showing implementations count, based on comment #604 (comment)

Closes issue(s):

  • NA

Pull Request Etiquette

When creating PR:

  • Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

@jeeyyy jeeyyy requested a review from WilcoFiers July 4, 2019 15:37
@jeeyyy jeeyyy merged commit 0a0fa60 into develop Jul 8, 2019
@jeeyyy jeeyyy deleted the fix-html-tag branch July 8, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants