fix: keep generated testcases files and assets #664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves for the missing test cases html files when publishing the site. A bug was recently introduced as a part of #604, where the logic for generating the test cases was moved out of a
gatsby
createNode
hook, into a standalone npm script namelycreateTestcases
. This npm script was executed as aprebuild
step tobuild > gatsby build
. Although all the necessary test case files and assets were created in thepublic
directory as expected in the script, they were being deleted bygatsby build
during itspreInit
step as shown below. (Note:gatsby develop
does not clear these files) & hence these files were missing when the site was published.This PR fixes the above issue, but changing the npm script to generate the test cases to a temporary directory
_data/rules-testcases
. Here all the necessary files, their assets thetestcases.json
files are generated. This directory can then be used as a one source of truth for all test cases.The contents of the directory are then copied across to the
public
directory during thepreBootstrap
hook of the gatsby build step. This ensures that the files are not cleaned up during thepreInit
step.Refer https://www.gatsbyjs.org/docs/node-apis/#onPreInit for more information on the various API's.
Closes issue(s):
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.How to Review And Approve