Skip to content

Conversation

jeeyyy
Copy link
Collaborator

@jeeyyy jeeyyy commented Jul 17, 2019

In this PR, some grammar is fixed and other missing references to glossary keys were updated.

As a consequence, it has been identified that some definitions are missing, which needs to be tackled separately in a different PR.

Closes issue(s):


Pull Request Etiquette

When creating PR:

  • Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

@jeeyyy jeeyyy changed the title update refs of glossary fix: update refs of glossary Jul 17, 2019
@jeeyyy jeeyyy merged commit a3a07db into develop Jul 17, 2019
@jeeyyy jeeyyy deleted the fix-up-glossary-refs branch July 17, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glossary-to-glossary links broken

2 participants