New rule: Device motion based functionality can be disabled #880

joao-vicente · 2019-09-09T16:07:50Z

Set of manual rules for SC 2.5.4: Motion Actuation

Reviewers required

Pull Request Etiquette

When creating PR:

Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR.
Add label to indicate if it's a Rule, Definition or Chore.
Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

…uation keys Reviews required

New rule: No keyboard shortcuts use only letter, number, sign or punctuation keys

Set of manual rules for SC 2.5.4: Motion Actuation

jeeyyy

Some comments to get you started. Will review the test cases in detail.

_rules/device-motion-bf0de1.md

_rules/motion-disabled-de951c.md

_rules/motion-replaced-5d9784.md

_rules/motion-disabled-de951c.md

_rules/motion-replaced-5d9784.md

_rules/motion-disabled-de951c.md

_rules/motion-replaced-5d9784.md

CLAassistant · 2019-09-24T10:23:02Z

All committers have signed the CLA.

_rules/device-motion-bf0de1.md

_rules/motion-replaced-5d9784.md

_rules/device-motion-bf0de1.md

_rules/motion-disabled-de951c.md

…tion'

_rules/motion-actuation-bf0de1.md

jeeyyy · 2019-10-09T08:25:09Z

@joao-vicente can you please dismiss reviews once you have caught up with the changes requested. Thanks.

Solved issues

_rules/device-motion-disabled-c249d5.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

changes made

_rules/device-motion-disabled-c249d5.md

adilsofficial

Good work. just a minor typo changes 👍

_rules/device-motion-disabled-c249d5.md

Co-authored-by: Adil Hussain <42895421+adilsofficial@users.noreply.github.com>

carlosapaduarte · 2020-06-30T13:30:09Z

Final call ends July 14

carlosapaduarte · 2020-07-14T17:58:37Z

Final call ended. Merging.

joao-vicente added 3 commits September 6, 2019 17:02

New rule No keyboard shortcuts use only letter, number, sign or punct…

0c30a4d

…uation keys Reviews required

Merge pull request #1 from joao-vicente/rule-no-single-key-shortcut

48079e0

New rule: No keyboard shortcuts use only letter, number, sign or punctuation keys

New rule No functions are exclusively operated through device motion

a3bb8e5

Set of manual rules for SC 2.5.4: Motion Actuation

joao-vicente added Rule Use this label for a new rule that does not exist already reviewers wanted labels Sep 9, 2019

joao-vicente assigned carlosapaduarte and joao-vicente Sep 9, 2019

carlosapaduarte added 7 commits September 9, 2019 17:10

Delete active-focus-shortcut-1e9941.md

3486f8b

Delete no-single-key-shortcut-ffbc54.md

e7428c8

Delete remap-shortcut-aa8b52.md

f6b1471

Delete turn-off-shortcut-670a30.md

6cc245e

Rename device-motion-bf0de1.md to _rules/device-motion-bf0de1.md

320e52f

Rename motion-disabled-de951c.md to _rules/motion-disabled-de951c.md

bd19733

Rename motion-replaced-5d9784.md to _rules/motion-replaced-5d9784.md

34806d9

jeeyyy previously requested changes Sep 11, 2019

View reviewed changes

Jym77 previously requested changes Sep 11, 2019

View reviewed changes

Jym77 mentioned this pull request Sep 12, 2019

New rule: No keyboard shortcuts use only letter, number, sign or punctuation keys #873

Merged

Update device-motion-bf0de1.md

fd78bc7

audreymaniez reviewed Sep 24, 2019

View reviewed changes

_rules/device-motion-bf0de1.md Outdated Show resolved Hide resolved

_rules/motion-replaced-5d9784.md Outdated Show resolved Hide resolved

_rules/device-motion-bf0de1.md Outdated Show resolved Hide resolved

_rules/motion-disabled-de951c.md Outdated Show resolved Hide resolved

joao-vicente and others added 2 commits September 25, 2019 11:02

updated rule 'No functions are exclusively operated through device mo…

6b7e369

…tion'

Merge branch 'develop' into rule-device-motion

4b61774

joecron previously requested changes Sep 25, 2019

View reviewed changes

_rules/motion-actuation-bf0de1.md Outdated Show resolved Hide resolved

Update motion-actuation-bf0de1.md

b38c90b

joao-vicente requested review from Jym77 and audreymaniez October 9, 2019 13:09

carlosapaduarte added 4 commits June 17, 2020 11:50

Merge branch 'develop' into rule-device-motion

4fd3f13

Update device-motion-disabled-c249d5.md

fbf482d

Merge branch 'develop' into rule-device-motion

fc7ad02

Update device-motion-disabled-c249d5.md

8dfcfae

WilcoFiers previously requested changes Jun 19, 2020

View reviewed changes

_rules/device-motion-disabled-c249d5.md Outdated Show resolved Hide resolved

carlosapaduarte and others added 2 commits June 19, 2020 18:20

Merge branch 'develop' into rule-device-motion

4a4877e

Update _rules/device-motion-disabled-c249d5.md

d5da2d3

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

carlosapaduarte requested a review from WilcoFiers June 19, 2020 17:23

WilcoFiers approved these changes Jun 22, 2020

View reviewed changes

WilcoFiers reviewed Jun 22, 2020

View reviewed changes

_rules/device-motion-disabled-c249d5.md Show resolved Hide resolved

carlosapaduarte and others added 2 commits June 23, 2020 10:25

Update device-motion-disabled-c249d5.md

a292207

Merge branch 'develop' into rule-device-motion

c657d52

adilsofficial approved these changes Jun 30, 2020

View reviewed changes

_rules/device-motion-disabled-c249d5.md Outdated Show resolved Hide resolved

_rules/device-motion-disabled-c249d5.md Outdated Show resolved Hide resolved

_rules/device-motion-disabled-c249d5.md Outdated Show resolved Hide resolved

carlosapaduarte and others added 8 commits June 30, 2020 13:57

Merge branch 'develop' into rule-device-motion

b0f8ee3

Apply suggestions from code review

9d137e6

Co-authored-by: Adil Hussain <42895421+adilsofficial@users.noreply.github.com>

fix spelling

1aaca8f

Create instrument.md

753f8b6

Create changes-in-content.md

2b55ee0

Create clearly-labeled-location.md

ba734fd

Update spelling-ignore.yml

58368dc

Merge branch 'develop' into rule-device-motion

9eaebbd

carlosapaduarte added the Review call 2 weeks Call for review for new rules and big changes label Jun 30, 2020

carlosapaduarte added 2 commits June 30, 2020 14:30

Merge branch 'develop' into rule-device-motion

967e707

Merge branch 'develop' into rule-device-motion

99f2eba

carlosapaduarte merged commit 1fbfedd into act-rules:develop Jul 14, 2020

carlosapaduarte removed Review call 2 weeks Call for review for new rules and big changes reviewers wanted labels Jul 14, 2020

New rule: Device motion based functionality can be disabled #880

New rule: Device motion based functionality can be disabled #880

Uh oh!

Conversation

joao-vicente commented Sep 9, 2019

Pull Request Etiquette

When creating PR:

After creating PR:

How to Review And Approve

Uh oh!

jeeyyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CLAassistant commented Sep 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeeyyy commented Oct 9, 2019

Uh oh!

Uh oh!

Uh oh!

adilsofficial left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlosapaduarte commented Jun 30, 2020

Uh oh!

carlosapaduarte commented Jul 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

CLAassistant commented Sep 24, 2019 •

edited

Loading