Skip to content

Fix test cases for orientation lock rule (b33eff) #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Fix test cases for orientation lock rule (b33eff) #942

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec7334d
Fix test cases for orientation lock rule
kasperisager Sep 25, 2019
714bcb7
Trigger CI
kasperisager Sep 25, 2019
b17c2f4
Merge branch 'develop' into orientation-lock-test-cases
kasperisager Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions _rules/css-restrict-orientation-b33eff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,30 +63,6 @@ _There are no major accessibility support issues known for this rule._

#### Passed Example 1

A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-transform) property is conditionally applied on the [orientation](https://www.w3.org/TR/css3-mediaqueries/#orientation) [media feature](https://www.w3.org/TR/css3-mediaqueries/#media1), but does not have any of the applicable [transformation functions](https://www.w3.org/TR/css-transforms/#transform-functions) which restricts the element to either `landscape` or `portrait` orientation.

```html
<html lang="en">
<head>
<title>Page with some content</title>
<style>
@media (orientation: portrait) {
body {
transform: translateX(100px);
}
}
</style>
</head>
<body>
<main>
Page Content
</main>
</body>
</html>
```

#### Passed Example 2

A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-transform) property has [rotateZ](https://drafts.csswg.org/css-transforms-2/#funcdef-rotatez) [transform function](https://www.w3.org/TR/css-transforms/#transform-functions) conditionally applied on the [orientation](https://www.w3.org/TR/css3-mediaqueries/#orientation) [media feature](https://www.w3.org/TR/css3-mediaqueries/#media1) which does not restrict the element to either `portrait` or `landscape` orientation.

```html
Expand All @@ -109,7 +85,7 @@ A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-trans
</html>
```

#### Passed Example 3
#### Passed Example 2

A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-transform) property has [matrix](https://www.w3.org/TR/css-transforms/#funcdef-transform-matrix) [transform function](https://www.w3.org/TR/css-transforms/#transform-functions) conditionally applied on the [orientation](https://www.w3.org/TR/css3-mediaqueries/#orientation) [media feature](https://www.w3.org/TR/css3-mediaqueries/#media1) which does not restrict the element to either `portrait` or `landscape` orientation.

Expand All @@ -133,7 +109,7 @@ A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-trans
</html>
```

#### Passed Example 4
#### Passed Example 3

A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-transform) property has [rotate](https://www.w3.org/TR/css-transforms/#funcdef-transform-rotate) [transform function](https://www.w3.org/TR/css-transforms/#transform-functions) conditionally applied on the [orientation](https://www.w3.org/TR/css3-mediaqueries/#orientation) [media feature](https://www.w3.org/TR/css3-mediaqueries/#media1) which matches the default CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-transform) applied on the target element.

Expand Down Expand Up @@ -170,7 +146,7 @@ A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-trans
<html lang="en">
<head>
<title>Page with some content</title>
<link rel="stylesheet" href="../test-assets/b33eff/style.css" />
<link rel="stylesheet" href="/test-assets/b33eff/style.css" />
</head>
<body>
Page Content
Expand Down Expand Up @@ -285,3 +261,28 @@ A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-trans
</body>
</html>
```

#### Inapplicable Example 5

A page where CSS [transform](https://www.w3.org/TR/css-transforms/#propdef-transform) property is conditionally applied on the [orientation](https://www.w3.org/TR/css3-mediaqueries/#orientation) [media feature](https://www.w3.org/TR/css3-mediaqueries/#media1), but does not have any of the applicable [transformation functions](https://www.w3.org/TR/css-transforms/#transform-functions) which restricts the element to either `landscape` or `portrait` orientation.

```html
<html lang="en">
<head>
<title>Page with some content</title>
<style>
@media (orientation: portrait) {
body {
transform: translateX(100px);
}
}
</style>
</head>
<body>
<main>
Page Content
</main>
</body>
</html>
```