Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

cargo-grcov is not working with hypens #51

Open
2 of 3 tasks
Luni-4 opened this issue Mar 28, 2020 · 8 comments
Open
2 of 3 tasks

cargo-grcov is not working with hypens #51

Luni-4 opened this issue Mar 28, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@Luni-4
Copy link
Contributor

Luni-4 commented Mar 28, 2020

Do the checklist before filing an issue:

Description

When I run the cargo-grcov action, I need to replace hypens with underscores in order to make it work. Unfortunately, if another subcrate is added, changing hypens to underscores break its compilation.

Used environment

  • os: ubuntu-latest

Workflow code

https://github.com/lu-zero/tree-sitter-core/blob/da91815b916a8a17fe3ef4ba63495df02e92d698/.github/workflows/tree-sitter-core.yml#L116

Action output

Searching for coverage files
  Found project crates: tree-sitter-core,tree-sitter-tests
##[error]Unable to find any coverage files, was `cargo test` executed correctly?

Expected behavior

cargo-grcov should run regardless of the hypens present in a crate name.

Additional context

Add any other context about the problem here.

@Luni-4 Luni-4 added the bug Something isn't working label Mar 28, 2020
@felipesere
Copy link

I am facing the same issue since having to rename by binary from fern to fern-run due to a clash on crates.io.

@watawuwu
Copy link

I also facing the same issue.
I avoid the names already published in cates.io by making the package name different from binary.

His PR will also solve my issue.
#59

dcuenot referenced this issue in dcuenot/gitlab-sonar-scanner-with-quality-gate Apr 30, 2020
@wolf4ood
Copy link

wolf4ood commented May 9, 2020

I'm also facing this issue with two hypens.

It seems that has been fixed here
749647d

But seems that it has not been released yet.

is there any date for the next release?

Thanks

@svartalf
Copy link
Member

Hey, everyone!

I'm working on the next version of this Action, which also should fix this one issue.
If anyone is up for some beta-testing, I would really appreciate any help; this branch contains more info about how to use it.

@wolf4ood
Copy link

Hi @svartalf

i've switched to 0.2-proto branch and it's working for me and it fixes this issue.

Here it's the run
https://github.com/wolf4ood/wait-for-me/actions/runs/107527380

Thanks :)

@Luni-4
Copy link
Contributor Author

Luni-4 commented May 18, 2020

Hello, everyone! :)

Since I can't test this issue anymore, if it's fixed for the others, it's fine for me. If it should happen again, I will reopen this issue.

Thanks for your fix, @svartalf! :)

@watawuwu
Copy link

I tried the 0.2proto branch and it worked fine.
Thank you for your fix!

@thibault-martinez
Copy link

Hello, has any progress been made on this issue ? What's the status of 0.2 ?
Thanks :)

rajivshah3 added a commit to iotaledger/crypto.rs that referenced this issue Jan 22, 2021
rajivshah3 added a commit to iotaledger/crypto.rs that referenced this issue Jan 22, 2021
rajivshah3 added a commit to iotaledger/crypto.rs that referenced this issue Jan 22, 2021
brouberol added a commit to brouberol/bo that referenced this issue May 22, 2022
brouberol added a commit to brouberol/bo that referenced this issue May 22, 2022
brouberol added a commit to brouberol/bo that referenced this issue May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

6 participants