-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to README how to checkout PR in issue_comment
event
#1248
base: main
Are you sure you want to change the base?
Conversation
I think the alternative with |
@zyv is that the same as the latest comment in the issue? If not, please share your version here. |
@ADTC nope, I meant this option: - uses: actions/checkout@v3
- run: hub pr checkout ${{ github.event.issue.number }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} Your option is nice, but it's only useful if you want to check out the code e.g. for static checks or something. The downside though is that if you check out the code your way, you can't use the resulting checkout to push the changes back to the branch with That's why I suggest to mention both alternatives if not the more generic one, and explain the caveat of your "nicer" solution, to spare folks trying to push their changes back banging the head against the wall for too long. |
@zyv what's the functional difference between your version and the one in this comment? Looks like they both do the same action, with yours being simpler code. Is that right? Also, what's the difference between |
Correct.
https://github.com/cli/cli/blob/trunk/docs/gh-vs-hub.md I guess you can just replace |
It will need to be tested. From what I gather, Also, are both |
Yes, see: Search for "GitHub CLI". |
Closes #331