-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Docker commands on Windows #1143
Comments
Hello, @michalb-dsg |
Hi @al-cheb |
@michalb-dsg , Currently nope, you can't install Docker Desktop in CI due to limitations of virtual environments:
|
@al-cheb 👌 |
@michalb-dsg, You can install docker and use minio/minio in runtime for macOS, because we already pre-installed virtualbox on macOS image. We can't pre-install docker on the macOS image due to license policy agreement.
Or the second variant provided by @telamonian - docker/for-mac#2359 (comment)
|
Feel free to open the thread if you have any concerns. |
@al-cheb now that Docker on Windows can use WSL to run Linux containers, is it possible to maybe reopen this? |
@ItalyPaleAle, WSL2 doesn't support current - |
@al-cheb Are the plans to upgrade the OS Version to support WSL2, or is this not possible for some reason? |
@alepauly, Do we have any plans to update Windows Server 2019? |
That would be most helpful. |
@al-cheb is WSL2 enabled on windows-latest? |
The ability to run docker on windows via WSL would be great, because if you need smth. like Electron (as we do) with a windows-build you could still use it. |
@h0p3zZ WSL2 has been removed from Windows Server 2022 so it's not possible to run Linux containers in WSL |
Alright... yeah thats real bad :D - still thanks though. Still... is there a way we can achieve the usecase I mentioned earlier? |
Not sure what are you trying to do, but Electron should work normally through NodeJS |
@catthehacker I'm trying to run the spectron tests in an Action. But when I try to run this in ubuntu-latest it does not work at all. In windows all tests pass in ubuntu none do. Therefore the request. |
- skip tests on windows (see actions/runner-images#1143)
- skip tests on windows (see actions/runner-images#1143) - skip tests on MacOS (actions/runner-images#2150)
- skip tests on windows (see actions/runner-images#1143) - skip tests on MacOS (actions/runner-images#2150)
This commit improves multiple aspects of Docker builds: - Enable artifact output validation for Dockerfile. - Correct the path references in Dockerfile for the distribution directory. - Add Dockerfile specific indentation rules to `.editorconfig`. - Use `npm run install-deps` for dependency installation, enhancing build reliability. - Add automation script `verify-web-server-status.js` to verify running web server on given URL. - Introduce automated build verification for Dockerfile: - On macOS, install Docker with colima as the container runtime because default agents do not include Docker and Docker runtime is not installed due to licensing issues (see actions/runner-images#17). - On Windows, there's no Linux container support (actions/runner#904, actions/runner-images#1143), so keep the checks for macOS and Ubuntu only.
This commit improves multiple aspects of Docker builds: - Enable artifact output validation for Dockerfile. - Correct the path references in Dockerfile for the distribution directory. - Add Dockerfile specific indentation rules to `.editorconfig`. - Use `npm run install-deps` for dependency installation, enhancing build reliability. - Add automation script `verify-web-server-status.js` to verify running web server on given URL. - Introduce automated build verification for Dockerfile: - On macOS, install Docker with colima as the container runtime because default agents do not include Docker and Docker runtime is not installed due to licensing issues (see actions/runner-images#17). - On Windows, there's no Linux container support (actions/runner#904, actions/runner-images#1143), so keep the checks for macOS and Ubuntu only.
Describe the bug
I'm new to GitHub Actions and facing a few Docker related issues. I'm using Docker SDK for Python, and my tests are failing because image pull is failing. I even added a step and tried to run
docker pull
command via CLI, and I discovered something strange. Some pulls are working, and others just don't.For example:
running the following step-
works just fine, but running this step-
will cause the following error:
image operating system "linux" cannot be used on this platform
##[error]Process completed with exit code 1.
I tried to pull the same image (
minio/minio
) on my own windows (10 pro, not server), and this command (docker pull minio/minio
) actually did work. I checked, and my configurations are standard (no experimental mode).Area for Triage:
Scripting and command line
Question, Bug, or Feature?:
Somewhere in between a question and a bug
Virtual environments affected
I want to understand why I'm not able to pull some images on Windows virtual environments. Is there a way to avoid it?
Thanks :)
(If any other information is needed, please ask)
The text was updated successfully, but these errors were encountered: