Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nesting group-endgroup workflow commands #802

Closed
andreineculau opened this issue Nov 12, 2020 · 3 comments
Closed

nesting group-endgroup workflow commands #802

andreineculau opened this issue Nov 12, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@andreineculau
Copy link

Describe the bug
Disclaimer: this might be a bug on the web frontend of Github Actions, but I have no idea where to report such bugs.

I am trying to use ::group:: and ::endgroup:: but the UI is confusing with nested groups. See details below.

To Reproduce

echo "::group::Wrapper"

echo "Wrapper begin"

echo "::group::Foo"
echo "Foo"
echo "::endgroup"

echo "Something"

echo "::group::Bar"
echo "Bar"
echo "::endgroup"

echo "Wrapper end"

echo "::endgroup::"

should be a reproducible snippet.

My actual build is https://github.com/rokmoln/support-firecloud/runs/1390151835?check_suite_focus=true#step:10:20

and the raw logs show

2020-11-12T11:49:27.8802160Z 11:49:27 [DO  ] Building...
2020-11-12T11:49:27.8805635Z ##[group]work-support-firecloud-support-firecloud-building
2020-11-12T11:49:27.8807942Z               > work-support-firecloud-support-firecloud-building
2020-11-12T11:49:27.8808756Z 
2020-11-12T11:49:27.8816470Z make[1]: Entering directory '/home/runner/work/support-firecloud/support-firecloud'
2020-11-12T11:49:28.1481071Z 
2020-11-12T11:49:28.1493809Z 11:49:28 [DO  ] Generating BUILD...
2020-11-12T11:49:28.1496163Z ##[group]work-support-firecloud-support-firecloud-generating-build
2020-11-12T11:49:28.1498510Z               > work-support-firecloud-support-firecloud-generating-build
2020-11-12T11:49:28.1499723Z 
2020-11-12T11:49:28.2640783Z 
2020-11-12T11:49:28.2643097Z               < work-support-firecloud-support-firecloud-generating-build
2020-11-12T11:49:28.2644640Z ##[endgroup]
2020-11-12T11:49:28.2656525Z 11:49:28 [DONE] Generating BUILD...
2020-11-12T11:49:28.2657112Z                 in 0 seconds
2020-11-12T11:49:28.2657435Z 
2020-11-12T11:49:28.4093908Z 
2020-11-12T11:49:28.4104975Z 11:49:28 [DO  ] Generating VERSION...
2020-11-12T11:49:28.4107301Z ##[group]work-support-firecloud-support-firecloud-generating-version
2020-11-12T11:49:28.4109658Z               > work-support-firecloud-support-firecloud-generating-version
2020-11-12T11:49:28.4111062Z 
2020-11-12T11:49:28.5241563Z 
2020-11-12T11:49:28.5243730Z               < work-support-firecloud-support-firecloud-generating-version
2020-11-12T11:49:28.5245349Z ##[endgroup]
2020-11-12T11:49:28.5257243Z 11:49:28 [DONE] Generating VERSION...
2020-11-12T11:49:28.5257839Z                 in 0 seconds
2020-11-12T11:49:28.5258388Z 
2020-11-12T11:49:28.5259812Z make[1]: Leaving directory '/home/runner/work/support-firecloud/support-firecloud'
2020-11-12T11:49:28.6347962Z 
2020-11-12T11:49:28.6349969Z               < work-support-firecloud-support-firecloud-building
2020-11-12T11:49:28.6351202Z ##[endgroup]
2020-11-12T11:49:28.6362789Z 11:49:28 [DONE] Building...
2020-11-12T11:49:28.6363358Z                 in 1 seconds

and it looks like the group/endgroup markers are set correctly.

Expected behavior
I expect groupings to be properly nested.

Runner Version and Platform

Version of your runner? 2.274.1

OS of the machine running the runner? Linux

What's not working?

It looks like the ##[group]work-support-firecloud-support-firecloud-generating-build (first nested group) acts as a ##[endgroup] for ##[group]work-support-firecloud-support-firecloud-building (the wrapper group).

Similarly the content after 2020-11-12T11:49:28.5257243Z 11:49:28 [DONE] Generating VERSION... and the following #endgroup# (the wrapper group) is not folded.

Screenshot 2020-11-12 at 13 18 33

Job Log Output

See above.

Runner and Worker's Diagnostic Logs

N/A
@andreineculau andreineculau added the bug Something isn't working label Nov 12, 2020
@Cyberbeni
Copy link

I think this is a feature request, not a bug.

I also think it would be useful to be able to create groups inside of groups and also run 2 groups parallelly (my use case is a typescript action, where the used commands also produce "uncontrolled" output inside @actions/exec), getting the output from them under the correct group. So something like this:

group 1: {
    group 1.1: {
        messages...
    }
    group 1.2: {
        messages...
    }
}
group 2: {
    group 2.1: {
        messages...
    }
    group 2.2: {
        messages...
    }
}

Where group 1 is started before group 2 but order of group 1.x and group 2.x and the messages inside them don't matter, they would all show in the appropriate place on the online log viewer.

@umarcor umarcor mentioned this issue Nov 12, 2021
Open
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: optionally mark up output in the GitHub workflow
f4f3784 
A couple of commands exist to spruce up the output in GitHub workflows:
https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions

In addition to the `::group::<label>`/`::endgroup::` commands (which we
already use to structure the output of the build step better), we also
use `::error::`/`::notice::` to draw the attention to test failures and
to test cases that were expected to fail but didn't.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
5ca5d24 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
8948fee 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
929f86e 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
096d83a 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
fd9ee9d 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
5df594c 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
e5a6726 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
d01a71a 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
c289a27 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
62fbeac 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
b87a831 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
69f553b 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
8d49557 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
58cae57 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
4a22d8a 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 16, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
e2ffacd 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping for each failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 17, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
c6d6756 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 17, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
e1b47fd 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 17, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
587e76f 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 17, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
fcb1cf6 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 17, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
42a66e5 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 17, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
f529ba5 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 19, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
9333ba7 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 19, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
1a6bd18 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 25, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
771e79d 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Jan 25, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
e5a57d4 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
avar pushed a commit to avar/git that referenced this issue Apr 19, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
a405a72 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
avar pushed a commit to avar/git that referenced this issue Apr 19, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
ad6d509 
[Ævar: due to re-structuring on top of my series the {begin,end}_group
in CI isn't needed at all to get "group" output for the test
suite. This commit includes the now-squashed "ci/run-build-and-tests:
add some structure to the GitHub workflow output":]

The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

[Ævar: The above comment isn't true anymore, as that limitation has
been removed by basing this on my patches to run "make" and "make
test" directly from the top-level of main.yml.

Those are now effectively their own "group", effectively giving this
stage another group "level" to use. This means that the equivalent of
"make test" won't be on the same level as an individual test failure.

We no longer take any pains to ensure balanced group output as a
result (which was a caveat the previous ci/lib.sh implementation had
to deal with., We just need to "cat" the generated *.markup]

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
avar pushed a commit to avar/git that referenced this issue Apr 20, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
877edff 
[Ævar: due to re-structuring on top of my series the {begin,end}_group
in CI isn't needed at all to get "group" output for the test
suite. This commit includes the now-squashed "ci/run-build-and-tests:
add some structure to the GitHub workflow output":]

The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

[Ævar: The above comment isn't true anymore, as that limitation has
been removed by basing this on my patches to run "make" and "make
test" directly from the top-level of main.yml.

Those are now effectively their own "group", effectively giving this
stage another group "level" to use. This means that the equivalent of
"make test" won't be on the same level as an individual test failure.

We no longer take any pains to ensure balanced group output as a
result (which was a caveat the previous ci/lib.sh implementation had
to deal with., We just need to "cat" the generated *.markup]

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
gitster pushed a commit to gitster/git that referenced this issue Apr 22, 2022
@dscho @gitster
ci: use --github-workflow-markup in the GitHub workflow
7e6f965 
[Ævar: due to re-structuring on top of my series the {begin,end}_group
in CI isn't needed at all to get "group" output for the test
suite. This commit includes the now-squashed "ci/run-build-and-tests:
add some structure to the GitHub workflow output":]

The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

[Ævar: The above comment isn't true anymore, as that limitation has
been removed by basing this on my patches to run "make" and "make
test" directly from the top-level of main.yml.

Those are now effectively their own "group", effectively giving this
stage another group "level" to use. This means that the equivalent of
"make test" won't be on the same level as an individual test failure.

We no longer take any pains to ensure balanced group output as a
result (which was a caveat the previous ci/lib.sh implementation had
to deal with., We just need to "cat" the generated *.markup]

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
87591f3 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
avar pushed a commit to avar/git that referenced this issue May 21, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
8cd28b1 
[Ævar: due to re-structuring on top of my series the {begin,end}_group
in CI isn't needed at all to get "group" output for the test
suite. This commit includes the now-squashed "ci/run-build-and-tests:
add some structure to the GitHub workflow output":]

The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

[Ævar: The above comment isn't true anymore, as that limitation has
been removed by basing this on my patches to run "make" and "make
test" directly from the top-level of main.yml.

Those are now effectively their own "group", effectively giving this
stage another group "level" to use. This means that the equivalent of
"make test" won't be on the same level as an individual test failure.

We no longer take any pains to ensure balanced group output as a
result (which was a caveat the previous ci/lib.sh implementation had
to deal with., We just need to "cat" the generated *.markup]

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
9a4f751 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
f2fdefe 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
b35361d 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
74e72cc 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
ca00ffa 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
d891a1a 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
8aa81bf 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
e3041e3 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
d3d421c 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci/run-build-and-tests: add some structure to the GitHub workflow output
7d22843 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 21, 2022
@dscho
ci: use --github-workflow-markup in the GitHub workflow
7f921ff 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
gitster pushed a commit to git/git that referenced this issue May 22, 2022
@dscho @gitster
ci/run-build-and-tests: add some structure to the GitHub workflow output
dab73ae 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitster pushed a commit to git/git that referenced this issue May 22, 2022
@dscho @gitster
ci: use --github-workflow-markup in the GitHub workflow
0068c82 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
avar pushed a commit to avar/git that referenced this issue May 24, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
12f5efd 
[Ævar: due to re-structuring on top of my series the {begin,end}_group
in CI isn't needed at all to get "group" output for the test
suite. This commit includes the now-squashed "ci/run-build-and-tests:
add some structure to the GitHub workflow output":]

The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

[Ævar: The above comment isn't true anymore, as that limitation has
been removed by basing this on my patches to run "make" and "make
test" directly from the top-level of main.yml.

Those are now effectively their own "group", effectively giving this
stage another group "level" to use. This means that the equivalent of
"make test" won't be on the same level as an individual test failure.

We no longer take any pains to ensure balanced group output as a
result (which was a caveat the previous ci/lib.sh implementation had
to deal with., We just need to "cat" the generated *.markup]

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
avar pushed a commit to avar/git that referenced this issue May 24, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
416e618 
[Ævar: due to re-structuring on top of my series the {begin,end}_group
in CI isn't needed at all to get "group" output for the test
suite. This commit includes the now-squashed "ci/run-build-and-tests:
add some structure to the GitHub workflow output":]

The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

[Ævar: The above comment isn't true anymore, as that limitation has
been removed by basing this on my patches to run "make" and "make
test" directly from the top-level of main.yml.

Those are now effectively their own "group", effectively giving this
stage another group "level" to use. This means that the equivalent of
"make test" won't be on the same level as an individual test failure.

We no longer take any pains to ensure balanced group output as a
result (which was a caveat the previous ci/lib.sh implementation had
to deal with., We just need to "cat" the generated *.markup]

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
avar pushed a commit to avar/git that referenced this issue May 24, 2022
@dscho @avar
ci/run-build-and-tests: add some structure to the GitHub workflow output
c34c7f6 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
avar pushed a commit to avar/git that referenced this issue May 24, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
8710251 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
avar pushed a commit to avar/git that referenced this issue May 31, 2022
@dscho @avar
ci/run-build-and-tests: add some structure to the GitHub workflow output
ecaba2a 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
avar pushed a commit to avar/git that referenced this issue May 31, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
3072031 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
avar pushed a commit to avar/git that referenced this issue Jun 6, 2022
@dscho @avar
ci/run-build-and-tests: add some structure to the GitHub workflow output
d1932e4 
The current output of Git's GitHub workflow can be quite confusing,
especially for contributors new to the project.

To make it more helpful, let's introduce some collapsible grouping.
Initially, readers will see the high-level view of what actually
happened (did the build fail, or the test suite?). To drill down, the
respective group can be expanded.

Note: sadly, workflow output currently cannot contain any nested groups
(see actions/runner#802 for details),
therefore we take pains to ensure to end any previous group before
starting a new one.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
avar pushed a commit to avar/git that referenced this issue Jun 6, 2022
@dscho @avar
ci: use --github-workflow-markup in the GitHub workflow
a674d5a 
This makes the output easier to digest.

Note: since workflow output currently cannot contain any nested groups
(see actions/runner#802 for details), we need
to remove the explicit grouping that would span the entirety of each
failed test script.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
@nikola-jokic
Copy link
Contributor

Hi @andreineculau,

Could you please post your feedback on the GitHub Feedback? As you said, the runner is correctly executing commands, so the feedback can ensure that maintainers of the board route the feedback to the correct team.
The issue does make sense to me, but since it is not related to the runner, I will close it now.

@oli-obk
Copy link

oli-obk commented Dec 7, 2022

The feature is tracked at actions/toolkit#1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oli-obk @andreineculau @Cyberbeni @nikola-jokic