Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

Make it working on macos #17

Closed
wants to merge 1 commit into from
Closed

Make it working on macos #17

wants to merge 1 commit into from

Conversation

niku
Copy link

@niku niku commented Feb 26, 2020

You can see testing result at https://github.com/niku/setup-elixir/actions/runs/45241114.

Notes

  • At this time, unlike linux, bob don't have prebuild package for macOS.
  • Homebrew that is package manager for macOS provides packages for erlang and elixir. However, these packages have limitations for version control. For example, elixir package provides only 1.10.1. Therefore, we can't install 1.9.1.

@axelson
Copy link

axelson commented Mar 28, 2020

Does this need anything before it can be merged? I'm trying to get elixir-lsp/vscode-elixir-ls#31 merged

@niku
Copy link
Author

niku commented Apr 2, 2020

It is ready to merge 👍 Go ahead please.

@jclem
Copy link
Contributor

jclem commented May 14, 2020

I've reached out to @ericmj to see if there's any plans to build for macOS, but it sounds like their current build platform doesn't offer macOS.

Not knowing exactly what the build dependencies are for OTP/Erlang and Elixir, it looks like this just works, for the most part, so maybe it's at least a good stop-gap solution.

@jclem
Copy link
Contributor

jclem commented May 14, 2020

@niku After thinking this through a bit more, I don't think we should offer a solution that builds from source—this would unfortunately re-build OTP and Elixir for every individual workflow run, and I'm wary of users accidentally eating up their usage with this action.

I'm going to close the PR and open an issue to discuss pre-built macOS images.

@jclem jclem closed this May 14, 2020
@jclem
Copy link
Contributor

jclem commented May 14, 2020

#23

@jclem jclem mentioned this pull request May 14, 2020
@niku
Copy link
Author

niku commented May 15, 2020

Thank you for your comment. I agree your concerns. I'll tackle to #23 .

@niku niku deleted the osx branch May 15, 2020 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants