Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve primary to route result cache #947

Closed
yanhuqing666 opened this issue Jan 23, 2019 · 4 comments
Closed

Improve primary to route result cache #947

yanhuqing666 opened this issue Jan 23, 2019 · 4 comments
Assignees
Labels
doc-it differ with mysql, and let it go Improvement resolve problem has been fixed by developer
Milestone

Comments

@yanhuqing666
Copy link
Member

Backgroud

Now only if query's filter contains primary key, we will add it to route cache.

Improve

For simple query,if result contains primary key, we can add it to route cache.

Effect

Not all cases need primary- route cache. Sometimes add to cache may cause performance reduction.
If no need, please do not setting primary key in table config.

@yanhuqing666 yanhuqing666 added this to the 2.19.01.0 milestone Jan 23, 2019
@yanhuqing666 yanhuqing666 added the doc-it differ with mysql, and let it go label Jan 23, 2019
@yanhuqing666 yanhuqing666 self-assigned this Jan 23, 2019
yanhuqing666 added a commit that referenced this issue Jan 24, 2019
@yanhuqing666
Copy link
Member Author

It suitable for this case:
sharding column is column1 and primarykey is column2.

yanhuqing666 added a commit that referenced this issue Jan 24, 2019
@yanhuqing666 yanhuqing666 added the resolve problem has been fixed by developer label Jan 24, 2019
@yanhuqing666
Copy link
Member Author

@yexiaoli88
Copy link

#969

@yexiaoli88
Copy link

verified on dble version: 5.6.29-dble-9.9.9.9-4e4db72053f13237a444c8fcc986db8660e38880-20190129085254

auto_test position: schema_attribute.feature scenario #6 #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-it differ with mysql, and let it go Improvement resolve problem has been fixed by developer
Projects
None yet
Development

No branches or pull requests

3 participants