Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use rw-split, mysql version and dble fakeMySQLVersion keep the same range #3638

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

LUAgam
Copy link
Member

@LUAgam LUAgam commented Mar 22, 2023

Reason:
  BUG inner-2051/#3726
Type:
  BUG
Influences:
fix: use rw-split, mysql version and dble fakeMySQLVersion keep the same range

mysqlVersion.setServerMajorVersion(Integer.parseInt(version.substring(0, point)));
} catch (NumberFormatException e) {
// ignore
LOGGER.warn("version[{}] format is wrong", version);

Check failure

Code scanning / CodeQL

Log Injection

This log entry depends on a [user-provided value](1).
mysqlVersion.setServerMinorVersion(Integer.parseInt(remaining.substring(0, point)));
} catch (NumberFormatException e) {
// ignore
LOGGER.warn("version[{}] format is wrong", version);

Check failure

Code scanning / CodeQL

Log Injection

This log entry depends on a [user-provided value](1).
mysqlVersion.setServerSubMinorVersion(Integer.parseInt(remaining.substring(0, pos)));
} catch (NumberFormatException e) {
// ignore
LOGGER.warn("version[{}] format is wrong", version);

Check failure

Code scanning / CodeQL

Log Injection

This log entry depends on a [user-provided value](1).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false positive, ignore

Copy link
Member

@PanternBao PanternBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LUAgam LUAgam merged commit b71c6b8 into master Mar 23, 2023
@LUAgam LUAgam deleted the fix/2051 branch March 23, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[improvement] use rw-split, mysql version and dble fakeMySQLVersion keep the same range
2 participants